You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/05/01 22:26:12 UTC

Re: Review Request 33040: Expose qdisc statistics from libnl


> On April 24, 2015, 10:53 p.m., Chi Zhang wrote:
> > src/linux/routing/queueing/statistics.cpp, line 99
> > <https://reviews.apache.org/r/33040/diff/8/?file=941228#file941228line99>
> >
> >     not sure if auto is whitelisted, as much as I'd like to embrace it. 
> >     
> >     @jieyu could you comment on this?

Use of auto is ok.


> On April 24, 2015, 10:53 p.m., Chi Zhang wrote:
> > src/linux/routing/queueing/statistics.hpp, line 27
> > <https://reviews.apache.org/r/33040/diff/8/?file=941227#file941227line27>
> >
> >     handle.hpp is only used in the implementation?

No, I expose handle as this is common between filters and disciplines


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33040/#review81563
-----------------------------------------------------------


On April 24, 2015, 7:28 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33040/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose qdisc statistics from libnl
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93c7c8a 
>   src/linux/routing/queueing/fq_codel.cpp 02ad8df 
>   src/linux/routing/queueing/ingress.cpp 47c7337 
>   src/linux/routing/queueing/internal.hpp 7c6c4d3 
>   src/linux/routing/queueing/statistics.hpp PRE-CREATION 
>   src/linux/routing/queueing/statistics.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp 7cc3b57 
> 
> Diff: https://reviews.apache.org/r/33040/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>