You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/01 08:11:12 UTC
[GitHub] [incubator-apisix] cyxinda opened a new pull request #1636: add skywalking plugin instructions
cyxinda opened a new pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
### Summary
SUMMARY_HERE
### Full changelog
* [Implement ...]
* [Add related tests]
* ...
### Issues resolved
Fix #XXX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] cyxinda commented on pull request #1636: add skywalking plugin instructions
Posted by GitBox <gi...@apache.org>.
cyxinda commented on pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636#issuecomment-637286618
I have removed the tabs character.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] cyxinda commented on pull request #1636: add skywalking plugin instructions
Posted by GitBox <gi...@apache.org>.
cyxinda commented on pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636#issuecomment-637994808
have done.
发自我的iPhone
> 在 2020年6月3日，上午10:00，Wen Ming <no...@github.com> 写道：
>
>
> Scan detected 15 error(s) in 2 file(s):
>
> [./doc/plugins/skywalking-cn.md]:
>
> 98: line has trailing whitespace.
>
> 102: line has trailing whitespace.
>
> 116: line has trailing whitespace.
>
> 122: line has trailing whitespace.
>
> 127: line has trailing whitespace.
>
> 128: line has trailing whitespace.
>
> 129: line has trailing whitespace.
>
> [./doc/plugins/skywalking.md]:
>
> 37: line has trailing whitespace.
>
> 85: line has trailing whitespace.
>
> 100: line has trailing whitespace.
>
> 104: line has trailing whitespace.
>
> 118: line has trailing whitespace.
>
> 124: line has trailing whitespace.
>
> 130: line has trailing whitespace.
>
> 131: line has trailing whitespace.
> @cyxinda please take a look
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on pull request #1636: add skywalking plugin instructions
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636#issuecomment-638020549
@cyxinda merged, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] cyxinda commented on pull request #1636: add skywalking plugin instructions
Posted by GitBox <gi...@apache.org>.
cyxinda commented on pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636#issuecomment-638159459
发自我的iPhone
> 在 2020年6月3日，下午3:41，Wen Ming <no...@github.com> 写道：
>
>
> @cyxinda merged, thx
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on pull request #1636: add skywalking plugin instructions
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636#issuecomment-637907902
```
Scan detected 15 error(s) in 2 file(s):
[./doc/plugins/skywalking-cn.md]:
98: line has trailing whitespace.
102: line has trailing whitespace.
116: line has trailing whitespace.
122: line has trailing whitespace.
127: line has trailing whitespace.
128: line has trailing whitespace.
129: line has trailing whitespace.
[./doc/plugins/skywalking.md]:
37: line has trailing whitespace.
85: line has trailing whitespace.
100: line has trailing whitespace.
104: line has trailing whitespace.
118: line has trailing whitespace.
124: line has trailing whitespace.
130: line has trailing whitespace.
131: line has trailing whitespace.
```
@cyxinda please take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1636: add skywalking plugin instructions
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636#issuecomment-636826981
please take a look at the outputs of Travis-CI:
https://travis-ci.org/github/apache/incubator-apisix/jobs/693361232
```
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 95 error(s) in 2 file(s):
[./doc/plugins/skywalking-cn.md]:
85: line contains tabs.
86: line contains tabs.
87: line contains tabs.
88: line contains tabs.
90: line contains tabs.
91: line contains tabs.
92: line contains tabs.
93: line contains tabs.
95: line contains tabs.
96: line contains tabs.
97: line contains tabs.
98: line contains tabs.
98: line has trailing whitespace.
99: line contains tabs.
100: line contains tabs.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming merged pull request #1636: add skywalking plugin instructions
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1636:
URL: https://github.com/apache/incubator-apisix/pull/1636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org