You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kyle Weaver (JIRA)" <ji...@apache.org> on 2019/02/11 21:46:00 UTC

[jira] [Commented] (BEAM-6257) Can we deprecate the side input paths through PAssert?

    [ https://issues.apache.org/jira/browse/BEAM-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765396#comment-16765396 ] 

Kyle Weaver commented on BEAM-6257:
-----------------------------------

It says side inputs are needed to make assertions about collection views in the docs:

[https://github.com/apache/beam/blob/247e93ef7fbe87dbb1cd82a0ce6b2e6aa5254f7c/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java#L786-L787]

Is that no longer true?

> Can we deprecate the side input paths through PAssert?
> ------------------------------------------------------
>
>                 Key: BEAM-6257
>                 URL: https://issues.apache.org/jira/browse/BEAM-6257
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: Major
>              Labels: starter
>
> PAssert has two distinct paths - one uses GBK with a single-firing trigger, and one uses side inputs. Side inputs are usually a later addition to a runner, while GBK is one of the first primitives (with a single firing it is even simple). Filing this against myself to figure out why the side input version is not deprecated, and if it can be deprecated.
> Marking this as a "starter" task because finding and eliminating side input version of PAssert should be fairly easy. You might need help but can ask on dev@



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)