[GitHub] [kafka] ableegoldman commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r740700461



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##########
@@ -385,7 +385,7 @@ public synchronized final InternalTopologyBuilder rewriteTopology(final StreamsC
         setApplicationId(config.getString(StreamsConfig.APPLICATION_ID_CONFIG));
 
         // maybe strip out caching layers
-        if (config.getLong(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG) == 0L) {
+        if (config.getLong(StreamsConfig.STATESTORE_CACHE_MAX_BYTES_CONFIG) == 0L) {

Review comment:
       Ah I wasn't trying to suggest we shouldn't start using the new config name everywhere, we absolutely should (even if it does explode the PR quite a bit -- I'll live). My point here was that we need to check the value of both of these configs, since we don't know which (if any) the user actually set.
   
   Which, by the way,  you can check via `config.originals()` -- this returns the set of configs the user passed in, otherwise it's tricky to figure out since eg `config.getLong` would return the config default value if not set




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org