[jira] [Comment Edited] (HAMA-941) Semiclustering Termination

["Behroz Sikander (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAMA-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265329#comment-15265329 ] 

Behroz Sikander edited comment on HAMA-941 at 4/30/16 2:25 PM:
---------------------------------------------------------------

According to Giraph implementation, our condition is wrong and should something like the following

if (!contains && cluster.vertices.size() < clusterCapacity) {
....
}

If I change the condition, out test case fails.

Further, semiClusterMaximumVertexCount in our test is set to 100 and the total vertices are also 100 in the data. This means that we can have 1 semi cluster with all the vertices. Which also does not seem correct. 


was (Author: bsikander):
According to Giraph implementation, our condition is wrong and should something like the following

if (!contains && cluster.vertices.size() < clusterCapacity) {
....
}

> Semiclustering Termination
> --------------------------
>
>                 Key: HAMA-941
>                 URL: https://issues.apache.org/jira/browse/HAMA-941
>             Project: Hama
>          Issue Type: Improvement
>          Components: examples, graph
>            Reporter: Edward J. Yoon
>            Priority: Minor
>
> Currently Semiclustering example will be terminated when the number of iterations exceeded the predefined threshold max iteration.
> App should be stopped if there's no cluster changes (I guess). Please check and improve it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)