You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by traflm <gi...@git.apache.org> on 2018/08/05 09:30:34 UTC
[GitHub] trafodion pull request #1679: [TRAFODION-3163] Add script to do STFS health ...
GitHub user traflm opened a pull request:
https://github.com/apache/trafodion/pull/1679
[TRAFODION-3163] Add script to do STFS health check
It is hard to test the STFS status if the cluster has many nodes and the STFS configured with many directories. This script will help to do basic checking.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/trafodion TRAFODION-3163
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1679.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1679
----
commit a864ee1c947182443ba370158529162628b46d76
Author: LiuMing <ov...@...>
Date: 2018-08-01T15:40:40Z
add command to dtmci
commit 399b2bdf5b65d2dff0e578461cdb03c8d2430577
Author: LiuMing <ov...@...>
Date: 2018-08-05T04:05:55Z
fix bugs
commit 0b3b5b9f4c2ff77b6fd05f495cf908ed32421ff5
Author: LiuMing <ov...@...>
Date: 2018-08-05T06:34:07Z
add a wrapper script
----
---
[GitHub] trafodion pull request #1679: [TRAFODION-3163] Add script to do STFS health ...
Posted by traflm <gi...@git.apache.org>.
Github user traflm commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1679#discussion_r208065409
--- Diff: core/sqf/src/tm/tools/dtmci.cpp ---
@@ -1801,6 +1801,20 @@ int main(int argc, char *argv[])
<< "' for status command." << endl;
}
}
+ else if (!strcmp(lp_nextcmd, "showenv"))
+ {
+ get_cmd(lp_inputstr, lp_nextcmd);
+ if (lp_nextcmd[0] == '\0')
+ cout <<"TODO: show all env var\n" << endl;
+ else
+ {
+ const char* v = ms_getenv_str((const char*)lp_nextcmd);
+ if(v == NULL)
+ cout <<"*** Enviorement Var not exist" << endl;
--- End diff --
thanks Dave, I will change this typo
---
[GitHub] trafodion pull request #1679: [TRAFODION-3163] Add script to do STFS health ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1679
---
[GitHub] trafodion pull request #1679: [TRAFODION-3163] Add script to do STFS health ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1679#discussion_r208041994
--- Diff: core/sqf/src/tm/tools/dtmci.cpp ---
@@ -1801,6 +1801,20 @@ int main(int argc, char *argv[])
<< "' for status command." << endl;
}
}
+ else if (!strcmp(lp_nextcmd, "showenv"))
+ {
+ get_cmd(lp_inputstr, lp_nextcmd);
+ if (lp_nextcmd[0] == '\0')
+ cout <<"TODO: show all env var\n" << endl;
+ else
+ {
+ const char* v = ms_getenv_str((const char*)lp_nextcmd);
+ if(v == NULL)
+ cout <<"*** Enviorement Var not exist" << endl;
--- End diff --
Typo. "Environment"
---