You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by GitBox <gi...@apache.org> on 2018/10/09 02:46:43 UTC

[GitHub] cxfeng1 closed pull request #1620: [iOS] Add keyboardSize in "keyboard" event.

cxfeng1 closed pull request #1620: [iOS] Add keyboardSize in "keyboard" event.
URL: https://github.com/apache/incubator-weex/pull/1620
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm b/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
index d93b19c75b..0df57d8d0f 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
@@ -904,8 +904,9 @@ - (void)keyboardWasShown:(NSNotification*)notification
     if(![self.view isFirstResponder]) {
         return;
     }
+    
+    CGRect end = [[[notification userInfo] objectForKey:@"UIKeyboardFrameEndUserInfoKey"] CGRectValue];
     if (!_disableMoveViewUp) {
-        CGRect end = [[[notification userInfo] objectForKey:@"UIKeyboardFrameEndUserInfoKey"] CGRectValue];
         _keyboardSize = end.size;
         UIView * rootView = self.weexInstance.rootView;
         CGRect screenRect = [[UIScreen mainScreen] bounds];
@@ -922,7 +923,7 @@ - (void)keyboardWasShown:(NSNotification*)notification
     }
     
     if (_keyboardEvent) {
-        [self fireEvent:@"keyboard" params:@{ @"isShow": @YES }];
+        [self fireEvent:@"keyboard" params:@{ @"isShow": @YES, @"keyboardSize": @{@"width": @(end.size.width), @"height": @(end.size.height)} }];
     }
     
     _keyboardHidden = NO;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services