[GitHub] [airflow] uranusjr commented on a change in pull request #19725: Adjust built-in base_aws methods to avoid Deprecation warnings

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #19725:
URL: https://github.com/apache/airflow/pull/19725#discussion_r755291087



##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -491,9 +491,9 @@ def conn(self) -> Union[boto3.client, boto3.resource]:
         :rtype: Union[boto3.client, boto3.resource]
         """
         if self.client_type:
-            return self.get_client_type(self.client_type, region_name=self.region_name)
+            return self.get_client_type(None, region_name=self.region_name)
         elif self.resource_type:
-            return self.get_resource_type(self.resource_type, region_name=self.region_name)
+            return self.get_resource_type(None, region_name=self.region_name)

Review comment:
       ```suggestion
               return self.get_resource_type(region_name=self.region_name)
   ```

##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -491,9 +491,9 @@ def conn(self) -> Union[boto3.client, boto3.resource]:
         :rtype: Union[boto3.client, boto3.resource]
         """
         if self.client_type:
-            return self.get_client_type(self.client_type, region_name=self.region_name)
+            return self.get_client_type(None, region_name=self.region_name)

Review comment:
       ```suggestion
               return self.get_client_type(region_name=self.region_name)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org