You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/08 20:59:51 UTC
[GitHub] [iceberg] jackye1995 opened a new pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
jackye1995 opened a new pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067
@samredai @rdblue
Given that we have a page for engine compatibility now in the website, I think it's better to refer to that in README instead of updating different places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067#discussion_r805201170
##########
File path: README.md
##########
@@ -79,5 +79,5 @@ This project Iceberg also has modules for adding Iceberg support to processing e
### Engine Compatibility
-See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page in the Iceberg website to know about Iceberg compatibility with different Spark, Flink and Trino versions.
+See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page to know about Iceberg compatibility with different Spark, Flink and Hive versions.
Review comment:
updated
##########
File path: README.md
##########
@@ -77,24 +77,7 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-mr` contains an InputFormat and other classes for integrating with Apache Hive
* `iceberg-pig` is an implementation of Pig's LoadFunc API for Iceberg
-### Compatibility
-
-Iceberg's Spark integration is compatible with Spark using the modules in the following table:
-
-| Iceberg version | Spark 2.4.x | Spark 3.0.x | Spark 3.1.x | Spark 3.2.x |
-| --------------- | --------------------- | ---------------------- | ------------------------------ | ------------------------------ |
-| master branch | iceberg-spark-runtime | iceberg-spark3-runtime | iceberg-spark-runtime-3.1_2.12 | iceberg-spark-runtime-3.2_2.12 |
-| 0.12.x | iceberg-spark-runtime | iceberg-spark3-runtime | iceberg-spark-runtime-3.1_2.12 | |
-| 0.11.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-| 0.10.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-| 0.9.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-
-Iceberg's Flink integration is compatible with Flink using the modules in the following table:
-
-| Iceberg version | Flink 1.11.x | Flink 1.12.x | Flink 1.13.x | Flink 1.14.x |
-| --------------- | --------------------- | -------------------------- | -------------------------- | -------------------------- |
-| master branch | | iceberg-flink-runtime-1.12 | iceberg-flink-runtime-1.13 | iceberg-flink-runtime-1.14 |
-| 0.12.x | | iceberg-flink-runtime | | |
-| 0.11.x | iceberg-flink-runtime | | | |
-| 0.10.x | iceberg-flink-runtime | | | |
+### Engine Compatibility
+See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page to know about Iceberg compatibility with different Spark, Flink and Hive versions.
+For other engines such as Presto and Trino, please visit their websites for Iceberg integration details.
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067#discussion_r805201170
##########
File path: README.md
##########
@@ -79,5 +79,5 @@ This project Iceberg also has modules for adding Iceberg support to processing e
### Engine Compatibility
-See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page in the Iceberg website to know about Iceberg compatibility with different Spark, Flink and Trino versions.
+See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page to know about Iceberg compatibility with different Spark, Flink and Hive versions.
Review comment:
updated
##########
File path: README.md
##########
@@ -77,24 +77,7 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-mr` contains an InputFormat and other classes for integrating with Apache Hive
* `iceberg-pig` is an implementation of Pig's LoadFunc API for Iceberg
-### Compatibility
-
-Iceberg's Spark integration is compatible with Spark using the modules in the following table:
-
-| Iceberg version | Spark 2.4.x | Spark 3.0.x | Spark 3.1.x | Spark 3.2.x |
-| --------------- | --------------------- | ---------------------- | ------------------------------ | ------------------------------ |
-| master branch | iceberg-spark-runtime | iceberg-spark3-runtime | iceberg-spark-runtime-3.1_2.12 | iceberg-spark-runtime-3.2_2.12 |
-| 0.12.x | iceberg-spark-runtime | iceberg-spark3-runtime | iceberg-spark-runtime-3.1_2.12 | |
-| 0.11.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-| 0.10.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-| 0.9.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-
-Iceberg's Flink integration is compatible with Flink using the modules in the following table:
-
-| Iceberg version | Flink 1.11.x | Flink 1.12.x | Flink 1.13.x | Flink 1.14.x |
-| --------------- | --------------------- | -------------------------- | -------------------------- | -------------------------- |
-| master branch | | iceberg-flink-runtime-1.12 | iceberg-flink-runtime-1.13 | iceberg-flink-runtime-1.14 |
-| 0.12.x | | iceberg-flink-runtime | | |
-| 0.11.x | iceberg-flink-runtime | | | |
-| 0.10.x | iceberg-flink-runtime | | | |
+### Engine Compatibility
+See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page to know about Iceberg compatibility with different Spark, Flink and Hive versions.
+For other engines such as Presto and Trino, please visit their websites for Iceberg integration details.
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067#discussion_r805135862
##########
File path: README.md
##########
@@ -77,24 +77,7 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-mr` contains an InputFormat and other classes for integrating with Apache Hive
* `iceberg-pig` is an implementation of Pig's LoadFunc API for Iceberg
-### Compatibility
-
-Iceberg's Spark integration is compatible with Spark using the modules in the following table:
-
-| Iceberg version | Spark 2.4.x | Spark 3.0.x | Spark 3.1.x | Spark 3.2.x |
-| --------------- | --------------------- | ---------------------- | ------------------------------ | ------------------------------ |
-| master branch | iceberg-spark-runtime | iceberg-spark3-runtime | iceberg-spark-runtime-3.1_2.12 | iceberg-spark-runtime-3.2_2.12 |
-| 0.12.x | iceberg-spark-runtime | iceberg-spark3-runtime | iceberg-spark-runtime-3.1_2.12 | |
-| 0.11.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-| 0.10.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-| 0.9.x | iceberg-spark-runtime | iceberg-spark3-runtime | | |
-
-Iceberg's Flink integration is compatible with Flink using the modules in the following table:
-
-| Iceberg version | Flink 1.11.x | Flink 1.12.x | Flink 1.13.x | Flink 1.14.x |
-| --------------- | --------------------- | -------------------------- | -------------------------- | -------------------------- |
-| master branch | | iceberg-flink-runtime-1.12 | iceberg-flink-runtime-1.13 | iceberg-flink-runtime-1.14 |
-| 0.12.x | | iceberg-flink-runtime | | |
-| 0.11.x | iceberg-flink-runtime | | | |
-| 0.10.x | iceberg-flink-runtime | | | |
+### Engine Compatibility
+See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page to know about Iceberg compatibility with different Spark, Flink and Hive versions.
+For other engines such as Presto and Trino, please visit their websites for Iceberg integration details.
Review comment:
s/Presto and Trino/Presto or Trino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067#discussion_r805135650
##########
File path: README.md
##########
@@ -79,5 +79,5 @@ This project Iceberg also has modules for adding Iceberg support to processing e
### Engine Compatibility
-See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page in the Iceberg website to know about Iceberg compatibility with different Spark, Flink and Trino versions.
+See [Multi-Engine Support](https://iceberg.apache.org/multi-engine-support/) page to know about Iceberg compatibility with different Spark, Flink and Hive versions.
Review comment:
small nit: `s/See/See the`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
hililiwei commented on pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067#issuecomment-1037037190
Will this article be versioned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067#issuecomment-1037525967
@samredai thanks for the review! @hililiwei will publish a new PR and ping you for the new experience, but to answer your question this page is not versioned and will include information across versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #4067: Docs: refer to multi-engine-support page for engine compatibility
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #4067:
URL: https://github.com/apache/iceberg/pull/4067#issuecomment-1037525967
@samredai thanks for the review! @hililiwei will publish a new PR and ping you for the new experience, but to answer your question this page is not versioned and will include information across versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org