[jira] [Commented] (SLING-7731) Call to addService is no longer needed for modification events in SlingAuthenticatorServiceListener

["Robert Munteanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511039#comment-16511039 ] 

Robert Munteanu commented on SLING-7731:
----------------------------------------

[~vfrey] - can you create a PR with the proposed change so we can discuss it and properly attribute it to you? Also, it would be good to see if any changes should be added to SlingAuthenticatorServiceListenerTest.

> Call to addService is no longer needed for modification events in SlingAuthenticatorServiceListener
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SLING-7731
>                 URL: https://issues.apache.org/jira/browse/SLING-7731
>             Project: Sling
>          Issue Type: Bug
>          Components: Authentication
>    Affects Versions: Auth Core 1.3.18
>            Reporter: Vincent Frey
>            Priority: Major
>
> After introduction of modifiedService(...) method in SlingAuthenticatorServiceListener, calling addService(...) is no longer needed for modification event.
> [https://github.com/apache/sling-org-apache-sling-auth-core/blob/master/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L85]
> Therefore line 85 should be changed from:
> {code}
> if ((event.getType() & (ServiceEvent.REGISTERED | ServiceEvent.MODIFIED)) != 0) {
> {code}
> to:
> {code}
> if ((event.getType() & ServiceEvent.REGISTERED) != 0) {
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)