You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/10/29 18:15:33 UTC
Review Request 71699: Consolidated 'Master::authorizeReserveResources'
overloads.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71699/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9990
https://issues.apache.org/jira/browse/MESOS-9990
Repository: mesos
Description
-------
Removed one overload of `authorizeReserveResources()` that was
not being used anywhere.
Diffs
-----
src/master/master.hpp dc45028d2ecfb61bf9ea82d90d2393af648a6023
src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff
Diff: https://reviews.apache.org/r/71699/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71699: Consolidated
'Master::authorizeReserveResources' overloads.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71699/#review218456
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Line 3783 (original), 3773-3774 (patched)
<https://reviews.apache.org/r/71699/#comment306181>
We seem to now only introduce this temporary for below log line. What do you think about iterating on `reserve.resources()` and e.g., logging it below (or the operation)?
- Benjamin Bannier
On Oct. 29, 2019, 7:15 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71699/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2019, 7:15 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9990
> https://issues.apache.org/jira/browse/MESOS-9990
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed one overload of `authorizeReserveResources()` that was
> not being used anywhere.
>
>
> Diffs
> -----
>
> src/master/master.hpp dc45028d2ecfb61bf9ea82d90d2393af648a6023
> src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff
>
>
> Diff: https://reviews.apache.org/r/71699/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71699: Consolidated
'Master::authorizeReserveResources' overloads.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71699/
-----------------------------------------------------------
(Updated Nov. 1, 2019, 3:59 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Removed temporary `resources`.
Bugs: MESOS-9990
https://issues.apache.org/jira/browse/MESOS-9990
Repository: mesos
Description
-------
Removed one overload of `authorizeReserveResources()` that was
not being used anywhere.
Diffs (updated)
-----
src/master/master.hpp dc45028d2ecfb61bf9ea82d90d2393af648a6023
src/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d
Diff: https://reviews.apache.org/r/71699/diff/2/
Changes: https://reviews.apache.org/r/71699/diff/1-2/
Testing
-------
Thanks,
Benno Evers