You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/27 16:29:09 UTC
[GitHub] [maven-source-plugin] jorsol opened a new pull request, #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
jorsol opened a new pull request, #4:
URL: https://github.com/apache/maven-source-plugin/pull/4
Since the plugin is a bit outdated, this aims to update all the dependencies used by maven-source-plugin.
Bump to Java 8
Require Maven 3.2.5+
Update parent-pom maven-plugins to 36
Maven bits scope set to provided
Update plexus-utils to 3.4.2
Update maven-plugin-testing-harness to 3.3.0
The update for maven-archiver will be handled in another issue.
---
https://issues.apache.org/jira/browse/MSOURCES-131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] cstamas commented on pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#issuecomment-1167933227
@jorsol and @slawekjaranowski thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] cstamas commented on pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#issuecomment-1167628048
Aside of parent pom rel path, looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] slawekjaranowski commented on pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#issuecomment-1167701630
GH action added - @jorsol please rebase
please also fix jenkins url ci-builds -> ci-maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] slawekjaranowski merged pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] jorsol commented on a diff in pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
jorsol commented on code in PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#discussion_r907638763
##########
pom.xml:
##########
@@ -25,12 +25,12 @@ under the License.
<parent>
<artifactId>maven-plugins</artifactId>
<groupId>org.apache.maven.plugins</groupId>
- <version>34</version>
+ <version>36</version>
<relativePath>../../pom/maven/maven-plugins/pom.xml</relativePath>
Review Comment:
👍🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] cstamas commented on a diff in pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#discussion_r907610991
##########
pom.xml:
##########
@@ -25,12 +25,12 @@ under the License.
<parent>
<artifactId>maven-plugins</artifactId>
<groupId>org.apache.maven.plugins</groupId>
- <version>34</version>
+ <version>36</version>
<relativePath>../../pom/maven/maven-plugins/pom.xml</relativePath>
Review Comment:
`<relativePath/>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] slawekjaranowski commented on pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#issuecomment-1167924727
@jorsol thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] slawekjaranowski commented on pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#issuecomment-1167681358
> there is no CI build?
ups ... no I will add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] cstamas commented on pull request #4: [MSOURCES-131] - Update plugin (requires Maven 3.2.5+)
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #4:
URL: https://github.com/apache/maven-source-plugin/pull/4#issuecomment-1167669035
there is no CI build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org