You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Norris Lee <no...@simba.com> on 2015/04/27 22:34:24 UTC
Review Request 33599: DRILL-2885: Return more precise error codes on
handshake failures in C++ client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33599/
-----------------------------------------------------------
Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.
Bugs: DRILL-2885
https://issues.apache.org/jira/browse/DRILL-2885
Repository: drill-git
Description
-------
Currently, when a handshake failure occurs, only a generic handshake error code is returned. Should be more granular for better error messages (Otherwise will have to resort to dumping whatever error message the server and client returns).
Diffs
-----
contrib/native/client/src/clientlib/drillClientImpl.cpp a253829
contrib/native/client/src/include/drill/common.hpp 6662754
Diff: https://reviews.apache.org/r/33599/diff/
Testing
-------
Thanks,
Norris Lee
Re: Review Request 33599: DRILL-2885: Return more precise error codes
on handshake failures in C++ client
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33599/#review82296
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On May 1, 2015, 11:21 p.m., Norris Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33599/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 11:21 p.m.)
>
>
> Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.
>
>
> Bugs: DRILL-2885
> https://issues.apache.org/jira/browse/DRILL-2885
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Currently, when a handshake failure occurs, only a generic handshake error code is returned. Should be more granular for better error messages (Otherwise will have to resort to dumping whatever error message the server and client returns).
>
>
> Diffs
> -----
>
> contrib/native/client/src/clientlib/drillClientImpl.cpp a253829
> contrib/native/client/src/include/drill/common.hpp 6662754
>
> Diff: https://reviews.apache.org/r/33599/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Norris Lee
>
>
Re: Review Request 33599: DRILL-2885: Return more precise error codes
on handshake failures in C++ client
Posted by Norris Lee <no...@simba.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33599/
-----------------------------------------------------------
(Updated May 1, 2015, 11:21 p.m.)
Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.
Bugs: DRILL-2885
https://issues.apache.org/jira/browse/DRILL-2885
Repository: drill-git
Description
-------
Currently, when a handshake failure occurs, only a generic handshake error code is returned. Should be more granular for better error messages (Otherwise will have to resort to dumping whatever error message the server and client returns).
Diffs (updated)
-----
contrib/native/client/src/clientlib/drillClientImpl.cpp a253829
contrib/native/client/src/include/drill/common.hpp 6662754
Diff: https://reviews.apache.org/r/33599/diff/
Testing
-------
Thanks,
Norris Lee