You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Sylvie-Wxr (via GitHub)" <gi...@apache.org> on 2024/03/06 06:30:34 UTC
[PR] [BanyanDB-UI] Use BanyanDB Browser' Icon and Remove Unused Buttons [skywalking-banyandb]
Sylvie-Wxr opened a new pull request, #402:
URL: https://github.com/apache/skywalking-banyandb/pull/402
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [x] If it's UI related, attach the screenshots below.
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11977.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
### Feature Description:
1. Removed Unused Buttons in red box
2. Use the BanyanDB Icon as the Browser's Icon
3. Update Browser Title to "BanyanDB"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Use BanyanDB Browser' Icon and Remove Unused Buttons [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #402:
URL: https://github.com/apache/skywalking-banyandb/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Use BanyanDB Browser' Icon and Remove Unused Buttons [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #402:
URL: https://github.com/apache/skywalking-banyandb/pull/402#issuecomment-1980190696
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/402?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 48.31%. Comparing base [(`71ad3c6`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/71ad3c681b2c155bfffdb869f137ff2fcfa73997?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ddd36b4`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/402?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #402 +/- ##
==========================================
- Coverage 48.35% 48.31% -0.05%
==========================================
Files 173 173
Lines 21566 21566
==========================================
- Hits 10429 10419 -10
- Misses 10265 10273 +8
- Partials 872 874 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/402?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org