[GitHub] Tibor17 commented on issue #193: [SUREFIRE-1564] ensure provider dependencies can be overriden

[GitBox <gi...@apache.org>]

Tibor17 commented on issue #193: [SUREFIRE-1564] ensure provider dependencies can be overriden
URL: https://github.com/apache/maven-surefire/pull/193#issuecomment-418640973
 
 
   @sormuras 
   The POM in platform provider contains `junit-platform-launcher`.
   I think that Romain's problem is with existence of this dependency in the provider classpath. I think it should have `<scope>provided</scope>`. Then the dependency would not appear in the provider's classpath and the user has to add.
   Another way would be more complicated for us but more user friendly for user. Discover the `junit-platform-launcher` and it transitive dependencies in dependencies and the algorithm would be complicated because it has to resolve them. Basically it has to use the launcher and engine if specified; otherwise use the one with version `1.2.0`. But this would lead to uncertain behavior because the users would not clearly understand when to use it and when not in certain versions.
   
   @rmannibucau 
   Why on why people still use plugin dependencies since the plugin has its own `ClassLoader` and has nothing to do with project dependencies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services