You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2025/10/13 08:09:02 UTC

Re: [PR] support millisecond timestamps in iceberg compatibility mode [paimon]

JingsongLi commented on code in PR #6352:
URL: https://github.com/apache/paimon/pull/6352#discussion_r2425510115


##########
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java:
##########
@@ -157,8 +157,8 @@ public static Object toPaimonObject(DataType type, byte[] bytes) {
                 long timestampLong =
                         ByteBuffer.wrap(bytes).order(ByteOrder.LITTLE_ENDIAN).getLong();
                 Preconditions.checkArgument(
-                        timestampPrecision > 3 && timestampPrecision <= 6,
-                        "Paimon Iceberg compatibility only support timestamp type with precision from 4 to 6.");
+                        timestampPrecision >= 3 && timestampPrecision <= 6,
+                        "Paimon Iceberg compatibility only support timestamp type with precision from 3 to 6.");
                 return Timestamp.fromMicros(timestampLong);

Review Comment:
   If precision is 3, this long should be a millis.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org