You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/13 17:04:30 UTC
[kudu-CR](branch-1.10.x) KUDU-2850: fix thrift comparison
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13636
Change subject: KUDU-2850: fix thrift comparison
......................................................................
KUDU-2850: fix thrift comparison
In the operator< implementations, we previously wouldn't return early
when determining that a field in the LHS was greater than that in the
RHS, when we should have returned false.
I added a test for each operator I updated that would fail without this
patch.
Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Reviewed-on: http://gerrit.cloudera.org:8080/13608
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit efb648e913452d02496d3cf63f843b8795b7dc12)
---
M src/kudu/sentry/thrift_operators-test.cc
M src/kudu/sentry/thrift_operators.cc
2 files changed, 82 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/13636/1
--
To view, visit http://gerrit.cloudera.org:8080/13636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13636
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.10.x) KUDU-2850: fix thrift comparison
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13636 )
Change subject: KUDU-2850: fix thrift comparison
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13636
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 Jun 2019 14:45:28 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) KUDU-2850: fix thrift comparison
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13636 )
Change subject: KUDU-2850: fix thrift comparison
......................................................................
KUDU-2850: fix thrift comparison
In the operator< implementations, we previously wouldn't return early
when determining that a field in the LHS was greater than that in the
RHS, when we should have returned false.
I added a test for each operator I updated that would fail without this
patch.
Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Reviewed-on: http://gerrit.cloudera.org:8080/13608
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit efb648e913452d02496d3cf63f843b8795b7dc12)
Reviewed-on: http://gerrit.cloudera.org:8080/13636
---
M src/kudu/sentry/thrift_operators-test.cc
M src/kudu/sentry/thrift_operators.cc
2 files changed, 82 insertions(+), 33 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13636
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)