You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/27 21:24:38 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #898: tools/sethost.sh: Correct error in setting a different host.
patacongo opened a new pull request #898:
URL: https://github.com/apache/incubator-nuttx/pull/898
## Summary
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations.
## Impact
This change resolves issue #386
sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:
$ tools/configure.sh -c stm32f4discovery:nsh
Copy files
Select CONFIG_HOST_WINDOWS=y
Select CONFIG_WINDOWS_CYGWIN=y
Refreshing...
.config:62:warning: override: reassigning to symbol HOST_WINDOWS
.config:62:warning: override: HOST_WINDOWS changes choice state
Those warnings are eliminated by this changed.
## Testing
Tested by repeatedly doing:
tools/configure.sh -c stm32f4discovery:nsh
I've also tested these configurations and they all work (after one forced push):
tools/configure.sh -c imxrt1060-evk:nsh # Linux to Windows Cygwin
rm .config Make.defs
tools/configure.sh -l imxrt1060-evk:nsh # Linux to Linux
rm .config Make.defs
tools/configure.sh -g imxrt1060-evk:nsh # Linux to MSYS
rm .config Make.defs
tools/configure.sh -l stm32f4discovery:nsh # Windows to Linux
rm .config Make.defs
tools/configure.sh -c stm32f4discovery:nsh # Windows to Windows Cygwin
rm .config Make.defs
tools/configure.sh -m stm32f4discovery:nsh # Windows to macOS
rm .config Make.defs
tools/configure.sh -g stm32f4discovery:nsh # Windows to Windows MSYS
rm .config Make.defs
tools/configure.sh -g sim:nsh # Linux to Windows MSYS
rm .config Make.defs
tools/configure.sh -l sim:nsh # Linux to Linux
rm .config Make.defs
tools/configure.sh -c sim:nsh # Linux to Windows Cygwin
rm .config Make.defs
tools/configure.sh -m sim:nsh # Linux to macOS
rm .config Make.defs
tools/configure.sh -l sim:module # macOS to Linux
rm .config Make.defs
tools/configure.sh -c sim:module # macOS to Windows Cygwin
At this point, I have not come up with any way that results in a corrupted defconfig file or in any warning from 'make olddefconfig'
BTW: If you want to experiment with this, you don't need to have Windows or a macOS. configure.sh doesn't care what platform you are on. So you can configure -l, -g, -c, -m on any plaform, including Linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #898: tools/sethost.sh: Correct error in setting a different host.
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #898:
URL: https://github.com/apache/incubator-nuttx/pull/898#issuecomment-620243972
@Ouss4 @btashton I don't know if you want to bring this bug fix into the release branch or not. I understand that you are going to cut the tarballs tonight. If you chose to include it, here is a PR that you could bring in all ready to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #898: tools/sethost.sh: Correct error in setting a different host.
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #898:
URL: https://github.com/apache/incubator-nuttx/pull/898#issuecomment-620243972
@Ouss4 @btashton I don't know if you want to bring this bugix onto the release branch or not. I understand that you are going to cut the tarballs tonight. I you chose to include it, here is a PR that you bring in all ready to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org