You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/24 15:57:33 UTC
[GitHub] [incubator-kyuubi] ldzhjn opened a new pull request #1630: [KYUUBI #1556]Upgrade swagger-ui version from 4.1.0 to 4.1.3
ldzhjn opened a new pull request #1630:
URL: https://github.com/apache/incubator-kyuubi/pull/1630
### _Why are the changes needed?_
Close https://github.com/apache/incubator-kyuubi/issues/1612
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [√] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn edited a comment on pull request #1630: [KYUUBI #1612] Upgrade swagger-ui version from 4.1.0 to 4.1.3
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #1630:
URL: https://github.com/apache/incubator-kyuubi/pull/1630#issuecomment-1001025364
@ldzhjn the committed author is not in your github account. Maybe you can add the email when you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1630: [KYUUBI #1612] Upgrade swagger-ui version from 4.1.0 to 4.1.3
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1630:
URL: https://github.com/apache/incubator-kyuubi/pull/1630#issuecomment-1001026207
> > @ldzhjn the committed author is not in your github account. Maybe you can add the email when you have time
>
> Sure, will do. In the mean time, do you mind masking the email in your comment please?
edited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ldzhjn commented on pull request #1630: [KYUUBI #1612] Upgrade swagger-ui version from 4.1.0 to 4.1.3
Posted by GitBox <gi...@apache.org>.
ldzhjn commented on pull request #1630:
URL: https://github.com/apache/incubator-kyuubi/pull/1630#issuecomment-1001025701
> @ldzhjn the committed author is not in your github account. Maybe you can add the email when you have time
Sure, will do.
In the mean time, do you mind masking the email in your comment please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1630: [KYUUBI #1612] Upgrade swagger-ui version from 4.1.0 to 4.1.3
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1630:
URL: https://github.com/apache/incubator-kyuubi/pull/1630#issuecomment-1001025364
@ldzhjn rayliu <ra...@cisco.com> the committed author is not in your github account. Maybe you can add the email when you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua closed pull request #1630: [KYUUBI #1556] Upgrade swagger-ui version from 4.1.0 to 4.1.3
Posted by GitBox <gi...@apache.org>.
yanghua closed pull request #1630:
URL: https://github.com/apache/incubator-kyuubi/pull/1630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1630: [KYUUBI #1556]Upgrade swagger-ui version from 4.1.0 to 4.1.3
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1630:
URL: https://github.com/apache/incubator-kyuubi/pull/1630#issuecomment-1000907316
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1630](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71fe05b) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/21f10d752dd172c04cca55c3c667b84cd4c23c16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21f10d7) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1630 +/- ##
=========================================
Coverage 58.32% 58.33%
Complexity 164 164
=========================================
Files 260 260
Lines 12930 12930
Branches 1633 1633
=========================================
+ Hits 7542 7543 +1
Misses 4756 4756
+ Partials 632 631 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../main/scala/org/apache/kyuubi/server/api/api.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL2FwaS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `85.00% <0.00%> (+2.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21f10d7...71fe05b](https://codecov.io/gh/apache/incubator-kyuubi/pull/1630?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org