You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kriSH-cD (via GitHub)" <gi...@apache.org> on 2025/11/25 10:03:18 UTC

[PR] scroll button added [airflow-site]

kriSH-cD opened a new pull request, #1289:
URL: https://github.com/apache/airflow-site/pull/1289

   **Feature: Add Scroll-to-Top Button (Fixes #1279)**
   Description
   
   This PR introduces a Scroll-to-Top button to improve page navigation on long content pages.
   The button becomes visible once the user scrolls past a certain point and allows them to return to the top smoothly with a single click.
   
   **Why This Is Useful**
   
   Enhances user experience and accessibility
   
   Reduces manual scrolling effort
   
   Improves navigation especially on long or content-heavy pages
   
   **Implementation Details**
   
   Button remains hidden initially and appears after scrolling beyond a defined threshold
   
   Smooth scrolling animation added for seamless experience
   
   Positioned unobtrusively at the bottom-right corner
   
   Styled to match the existing UI theme
   
   **Testing**
   
   Verified that button visibility toggles correctly on scroll
   
   Confirmed smooth scroll behavior on click
   
   Tested responsiveness across different screen sizes and devices
   
   Checked compatibility across major browsers
   
   **Preview (video)**
   Here is the video of button working.
   <img width="1800" height="1169" alt="Screenshot 2025-11-17 at 00 59 41" src="https://github.com/user-attachments/assets/b23c471d-6c85-46dc-a5d8-d8b710c698f8" />
   
   
   
   
   @choo121600 Please review it .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#issuecomment-3617149403

   Indeed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "kriSH-cD (via GitHub)" <gi...@apache.org>.
kriSH-cD commented on PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#issuecomment-3619619661

   Thank you for the update! 
   I’m glad the issue has already been resolved in #1293.
   
   I appreciate the review, and I’ll be happy to contribute to your organization in the future as well. Looking forward to more opportunities to help!
   
   Thanks again! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "kriSH-cD (via GitHub)" <gi...@apache.org>.
kriSH-cD commented on code in PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#discussion_r2559420507


##########
landing-pages/site/assets/scss/main-custom.scss:
##########
@@ -57,48 +57,4 @@
 @import "survey";
 @import "testimonial";
 @import "suggest-change";
-
-/* Blog Snippet Section */
-.blog-snippet-list {
-    display: grid;
-    gap: 1.2rem;
-    grid-template-columns: 1fr;
-}
-
-.blog-snippet-item {
-    padding: 1rem 1.25rem;
-    border-radius: 8px;
-    background: rgba(255, 255, 255, 0.03);
-    border: 1px solid rgba(255, 255, 255, 0.07);
-    transition: 0.2s ease;
-}
-
-.blog-snippet-item:hover {
-    transform: translateY(-3px);
-    border-color: rgba(100, 200, 255, 0.6);
-    background: rgba(255, 255, 255, 0.05);
-}
-
-.blog-snippet-title {
-    margin: 0.25rem 0;
-    font-size: 1.1rem;
-}
-
-.blog-snippet-title a {
-    text-decoration: none;
-}
-
-.blog-snippet-title a:hover {
-    text-decoration: underline;
-}
-
-.blog-snippet-excerpt {
-    margin: 0;
-    opacity: 0.85;
-    font-size: 0.95rem;
-}
-
-.blog-snippet-item time {
-    font-size: 0.8rem;
-    opacity: 0.7;
-}

Review Comment:
   Hi, thank you for reviewing!
   It looks like I mistakenly removed some code — sorry about that. 
   Please give me a little time, I’ll correct it and resolve the issue shortly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#issuecomment-3574822323

   The preview video was attached incorrectly. 
   Please update it with the correct preview.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #1289: scroll button added
URL: https://github.com/apache/airflow-site/pull/1289


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "kriSH-cD (via GitHub)" <gi...@apache.org>.
kriSH-cD commented on PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#issuecomment-3592473551

   Hey @choo121600 can you please review my updates.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#discussion_r2559394033


##########
landing-pages/site/assets/scss/main-custom.scss:
##########
@@ -57,48 +57,4 @@
 @import "survey";
 @import "testimonial";
 @import "suggest-change";
-
-/* Blog Snippet Section */
-.blog-snippet-list {
-    display: grid;
-    gap: 1.2rem;
-    grid-template-columns: 1fr;
-}
-
-.blog-snippet-item {
-    padding: 1rem 1.25rem;
-    border-radius: 8px;
-    background: rgba(255, 255, 255, 0.03);
-    border: 1px solid rgba(255, 255, 255, 0.07);
-    transition: 0.2s ease;
-}
-
-.blog-snippet-item:hover {
-    transform: translateY(-3px);
-    border-color: rgba(100, 200, 255, 0.6);
-    background: rgba(255, 255, 255, 0.05);
-}
-
-.blog-snippet-title {
-    margin: 0.25rem 0;
-    font-size: 1.1rem;
-}
-
-.blog-snippet-title a {
-    text-decoration: none;
-}
-
-.blog-snippet-title a:hover {
-    text-decoration: underline;
-}
-
-.blog-snippet-excerpt {
-    margin: 0;
-    opacity: 0.85;
-    font-size: 0.95rem;
-}
-
-.blog-snippet-item time {
-    font-size: 0.8rem;
-    opacity: 0.7;
-}

Review Comment:
   Why is this code being removed?



##########
landing-pages/site/layouts/partials/suggest-change.html:
##########
@@ -23,3 +23,9 @@
         {{ partial "buttons/button-with-icon" (dict "text" "Suggest a change on this page" "class" "button-fixed") }}
     </a>
 </div>
+
+<!-- Scroll to Top Button -->
+<button id="scrollToTopBtn">▲</button>
+

Review Comment:
   I don’t think this code should be added here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#discussion_r2559457019


##########
landing-pages/site/layouts/partials/suggest-change.html:
##########
@@ -23,3 +23,9 @@
         {{ partial "buttons/button-with-icon" (dict "text" "Suggest a change on this page" "class" "button-fixed") }}
     </a>
 </div>
+
+<!-- Scroll to Top Button -->
+<button id="scrollToTopBtn">▲</button>
+

Review Comment:
   Yes, I think it would be best to implement it in a way similar to "Suggest a change on this page" button.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#issuecomment-3616885786

   Thank you for contributing to the airflow-site project. however, #1293 addressed the same issue earlier and has already been merged, so the issue has been resolved.
   Therefore, we can close this PR.
   Looking forward to your future contributions! 😉


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "kriSH-cD (via GitHub)" <gi...@apache.org>.
kriSH-cD commented on code in PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#discussion_r2559611597


##########
landing-pages/site/layouts/partials/suggest-change.html:
##########
@@ -23,3 +23,9 @@
         {{ partial "buttons/button-with-icon" (dict "text" "Suggest a change on this page" "class" "button-fixed") }}
     </a>
 </div>
+
+<!-- Scroll to Top Button -->
+<button id="scrollToTopBtn">▲</button>
+

Review Comment:
   Hey @choo121600 i have added new section for the button . please review it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#discussion_r2559694294


##########
landing-pages/site/layouts/partials/suggest-change.html:
##########
@@ -23,3 +23,9 @@
         {{ partial "buttons/button-with-icon" (dict "text" "Suggest a change on this page" "class" "button-fixed") }}
     </a>
 </div>
+
+<!-- Scroll to Top Button -->
+<button id="scrollToTopBtn">▲</button>
+

Review Comment:
   I don't think the scrollToTop button belongs in `landing-pages/site/layouts/partials/suggest-change.html`.
   since they serve different functions.



##########
landing-pages/site/layouts/_default/baseof.html:
##########
@@ -1,44 +1,48 @@
 {{/*
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements.  See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership.  The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License.  You may obtain a copy of the License at
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
 
-   http://www.apache.org/licenses/LICENSE-2.0
+http://www.apache.org/licenses/LICENSE-2.0
 
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied.  See the License for the
- specific language governing permissions and limitations
- under the License.
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
 */}}

Review Comment:
   This must not be changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] scroll button added [airflow-site]

Posted by "kriSH-cD (via GitHub)" <gi...@apache.org>.
kriSH-cD commented on code in PR #1289:
URL: https://github.com/apache/airflow-site/pull/1289#discussion_r2559425932


##########
landing-pages/site/layouts/partials/suggest-change.html:
##########
@@ -23,3 +23,9 @@
         {{ partial "buttons/button-with-icon" (dict "text" "Suggest a change on this page" "class" "button-fixed") }}
     </a>
 </div>
+
+<!-- Scroll to Top Button -->
+<button id="scrollToTopBtn">▲</button>
+

Review Comment:
   Okay , can i add new section for this button ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org