You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/03 09:30:38 UTC

[GitHub] [flink] pnowojski opened a new pull request #15824: (1.11) [FLINK-20383][runtime] Fix race condition in notification. 

pnowojski opened a new pull request #15824:
URL: https://github.com/apache/flink/pull/15824


   This is a back port of https://github.com/apache/flink/pull/14240 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15824: (1.11) [FLINK-20383][runtime] Fix race condition in notification.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15824:
URL: https://github.com/apache/flink/pull/15824#issuecomment-831142161


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f741e9ec3edf512b0adf4eb17548f9bf073f00ff (Fri May 28 11:08:12 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15824: (1.11) [FLINK-20383][runtime] Fix race condition in notification.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15824:
URL: https://github.com/apache/flink/pull/15824#issuecomment-831161678


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f741e9ec3edf512b0adf4eb17548f9bf073f00ff",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f741e9ec3edf512b0adf4eb17548f9bf073f00ff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f741e9ec3edf512b0adf4eb17548f9bf073f00ff UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15824: (1.11) [FLINK-20383][runtime] Fix race condition in notification.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15824:
URL: https://github.com/apache/flink/pull/15824#issuecomment-831161678


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f741e9ec3edf512b0adf4eb17548f9bf073f00ff",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17512",
       "triggerID" : "f741e9ec3edf512b0adf4eb17548f9bf073f00ff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f741e9ec3edf512b0adf4eb17548f9bf073f00ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17512) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15824: (1.11) [FLINK-20383][runtime] Fix race condition in notification.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15824:
URL: https://github.com/apache/flink/pull/15824#issuecomment-831161678


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f741e9ec3edf512b0adf4eb17548f9bf073f00ff",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17512",
       "triggerID" : "f741e9ec3edf512b0adf4eb17548f9bf073f00ff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f741e9ec3edf512b0adf4eb17548f9bf073f00ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17512) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15824: (1.11) [FLINK-20383][runtime] Fix race condition in notification.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15824:
URL: https://github.com/apache/flink/pull/15824#issuecomment-831142161


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0ea8047ed26e91e0a8cdd951008340834a93d545 (Mon May 03 09:32:59 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski merged pull request #15824: (1.11) [FLINK-20383][runtime] Fix race condition in notification.

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #15824:
URL: https://github.com/apache/flink/pull/15824


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org