[GitHub] spark pull request #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to ...

[wangyum <gi...@git.apache.org>]

Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22488#discussion_r221780844
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
    @@ -242,75 +249,22 @@ object DatasetBenchmark {
         benchmark
       }
     
    -  def main(args: Array[String]): Unit = {
    -    val spark = SparkSession.builder
    +  override def getSparkSession: SparkSession = {
    --- End diff --
    
    Need override default `SparkSession` as default `SparkSession` is:
    ```scala
        SparkSession.builder()
          .master("local[1]")
          .appName(this.getClass.getCanonicalName)
          .config(SQLConf.SHUFFLE_PARTITIONS.key, 1)
          .config(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key, 1)
          .getOrCreate()
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org