You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/07/14 16:11:54 UTC

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #592: OAK-9800 update Maven plugins to most recent version

mreutegg commented on code in PR #592:
URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r921331698


##########
oak-parent/pom.xml:
##########
@@ -868,7 +828,7 @@
 
    <!--  - - - - - - - - - - - - - - - - - - - will run all the required tests before a release -->
    <profile>
-      <id>release</id>

Review Comment:
   You mean while creating a release? I think the one in the reactor root. When I created the current 1.44.0 release I did not specify the profile `release`. I just ran the maven release commands without setting any profile explicitly.
   
   This release profile was created with https://issues.apache.org/jira/browse/OAK-4136
   
   I still don't quite understand why it was created, but I would rather refrain from changing the profile name to `apache-release`. I think it might mess up the release process.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org