You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/08 04:02:09 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request, #15081: commit comments
gaozhangmin opened a new pull request, #15081:
URL: https://github.com/apache/pulsar/pull/15081
Fixes #14851
### Motivation
Let exception thrown on broker server side.
### Modifications
Remove try catching exception. handle exception by asyncResponse
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `no-need-doc`
code optimize. no new feature added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1092497384
> This PR doesn't seem to fix the #14851 . I think we need to find the root cause of this issue.
Only add logs when error. It's not related to #14851.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin merged pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin merged PR #15081:
URL: https://github.com/apache/pulsar/pull/15081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1092820412
@gaozhangmin
Would you mind checking this code, looks this method will invoke ``validateTopicOwnershipAsync``?
https://github.com/apache/pulsar/blob/8757c3acf3456af64d3f4f8ffbb3202a6c18e02a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java#L145-L149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1094582383
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Solve rest api exceptions don't throw on broker server side
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1092448942
> Looks like you just add the error log here, a little bit confused about your PR title and description.
Without this, broker server side logged nothing as issue #14851.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1094672958
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1092785710
> Looks like we will return 307, and this redirect exception may don't need to log error.
>
> `@ApiResponse(code = 307, message = "Topic is not owned by this broker!"),`
@mattisonchao redirection exception is thrown in method `validateTopicName`. This error won't be caught by CompletableFuture exceptionally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1094955151
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1094717372
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1093135025
@mattisonchao PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15081: [improve][transaction] Solve rest api exceptions don't throw on broker server side
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1092434648
Looks like you just add the error log here, a little bit confused about your PR title and description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #15081: [improve][transaction] Add logs for REST API in transaction
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15081:
URL: https://github.com/apache/pulsar/pull/15081#issuecomment-1092507443
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org