You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2014/12/22 19:27:48 UTC

[Bug 57389] New: Potential NPE in converters

https://issues.apache.org/bugzilla/show_bug.cgi?id=57389

            Bug ID: 57389
           Summary: Potential NPE in converters
           Product: JMeter
           Version: 2.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: felix.schumacher@internetallee.de

Created attachment 32320
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32320&action=edit
Fix potential NPE in converters

in the converters in org.apache.jmeter.save.converters there are a few possible
NPE. In the method canConvert(Class) often the implementation looks like

 "return arg0.equals(SomeClass.class)"

without arg0 being checked for non-null.

I would reverse the logic to

 "return SomeClass.class.equals(arg0)"

This is null safe and should return the same values (apart from possible NPE).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57389] Potential NPE in converters

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57389

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Date: Mon Dec 22 18:33:59 2014
New Revision: 1647367

URL: http://svn.apache.org/r1647367
Log:
Bug 57389: Fix potential NPE in org.apache.jmeter.save.converters
Bugzilla Id: 57389

Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/save/converters/BooleanPropertyConverter.java
   
jmeter/trunk/src/core/org/apache/jmeter/save/converters/IntegerPropertyConverter.java
   
jmeter/trunk/src/core/org/apache/jmeter/save/converters/LongPropertyConverter.java
   
jmeter/trunk/src/core/org/apache/jmeter/save/converters/MultiPropertyConverter.java
   
jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java
   
jmeter/trunk/src/core/org/apache/jmeter/save/converters/TestElementPropertyConverter.java
   
jmeter/trunk/src/core/org/apache/jmeter/save/converters/TestResultWrapperConverter.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.