[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9665: [fix] Ensuring cache warmup respects request form data

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#discussion_r417032478



##########
File path: superset/views/utils.py
##########
@@ -101,15 +101,18 @@ def get_viz(
 
 def get_form_data(slice_id=None, use_slice_data=False):
     form_data = {}
-    post_data = request.form.get("form_data")

Review comment:
       @villebro I was spinning my wheels for quite some time trying to get `test_request_context()` to work and then realize that this isn't explicitly related to the POST method and not is the body of the request a JSON object, i.e., the `form_data` field is actually further encoded as a JSON object. 
   
   The form-data is messy and we probably should strive to standardize this at some stage. For now I've renamed `post_data` as `request_form_data` which is more accurate.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org