[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #283: Add projectStrict for Dates and Timestamps

[GitBox <gi...@apache.org>]

moulimukherjee commented on a change in pull request #283: Add projectStrict for Dates and Timestamps
URL: https://github.com/apache/incubator-iceberg/pull/283#discussion_r304702169
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java
 ##########
 @@ -253,5 +286,32 @@ public Expression or(Expression leftResult, Expression rightResult) {
       // if binding didn't result in a Predicate, return the expression
       return bound;
     }
+
+    // Overriding some behaviour for inclusive projections
+    public <T> Expression predicateInclusive(BoundPredicate<T> pred) {
 
 Review comment:
   Let me know if this could have been refactored better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org