DO NOT REPLY [Bug 43161] New: - wrong construction of the DIB picture header

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43161>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43161

           Summary: wrong construction of the DIB picture  header
           Product: POI
           Version: unspecified
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSLF
        AssignedTo: dev@poi.apache.org
        ReportedBy: michael.vilensky@gmail.com


hey!

imho, there are some incorrectness in the construction of the DIB header:

" //Specifies the size, in bytes, of the bitmap file.
        LittleEndian.putInt(header, 2, data.length); //DIB length including 
the header"

well, if it specifies the size of the file including the header then it should 
be something like:
LittleEndian.putInt(header, 2, data.length + header.lenght); 

"//the offset, in bytes, from the header to the bitmap bits (looks like it is 
always 2)
        LittleEndian.putInt(header, 10, 2);"

the size of the header is 14 bytes, so this field should be at least 14 (this 
is the basic header, almost in all DIB's there are another header following 
this one, but I don't know should it be here or not...) so if you use only 
this header, this fiels should be exactly 14.

hope this info will be useful.

mike.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org