You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Chinna Rao Lalam (JIRA)" <ji...@apache.org> on 2012/04/23 12:19:34 UTC
[jira] [Created] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Chinna Rao Lalam created HBASE-5857:
---------------------------------------
Summary: RIT map in RS not getting cleared while region opening
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259840#comment-13259840 ]
Chinna Rao Lalam commented on HBASE-5857:
-----------------------------------------
@Uma: Thanks for the review. i addressed u r comments in the latest patch.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259782#comment-13259782 ]
Chinna Rao Lalam commented on HBASE-5857:
-----------------------------------------
@Stack : Thanks for the review.
That is also good way of verifying instead of doing another opertion.I will update the patch with this change.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HBASE-5857:
------------------------------------
Attachment: HBASE-5857_trunk.1.patch
HBASE-5857_0.94.1.patch
HBASE-5857_0.92.1.patch
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260098#comment-13260098 ]
Zhihong Yu commented on HBASE-5857:
-----------------------------------
Patch for 0.92 (HBASE-5857_0.92.1.patch) applies cleanly and TestZKBasedOpenCloseRegion passes based on patch.
Integrated to 0.92 branch.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HBASE-5857:
------------------------------------
Status: Patch Available (was: Open)
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5857:
-------------------------
Attachment: HBASE-5857_trunk.2.patch
This is the version I applied. Same as trunk.1.patch but w/ the tabs removed replaced by two spaces.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259903#comment-13259903 ]
Hadoop QA commented on HBASE-5857:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523843/HBASE-5857_trunk.1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1612//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1612//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1612//console
This message is automatically generated.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261226#comment-13261226 ]
Hudson commented on HBASE-5857:
-------------------------------
Integrated in HBase-0.94-security #20 (See [https://builds.apache.org/job/HBase-0.94-security/20/])
HBASE-5857 RIT map in RS not getting cleared while region opening (Revision 1329471)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260048#comment-13260048 ]
Hudson commented on HBASE-5857:
-------------------------------
Integrated in HBase-TRUNK #2801 (See [https://builds.apache.org/job/HBase-TRUNK/2801/])
HBASE-5857 RIT map in RS not getting cleared while region opening (Revision 1329470)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam reassigned HBASE-5857:
---------------------------------------
Assignee: Chinna Rao Lalam
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260087#comment-13260087 ]
Hudson commented on HBASE-5857:
-------------------------------
Integrated in HBase-0.94 #138 (See [https://builds.apache.org/job/HBase-0.94/138/])
HBASE-5857 RIT map in RS not getting cleared while region opening (Revision 1329471)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260264#comment-13260264 ]
Hudson commented on HBASE-5857:
-------------------------------
Integrated in HBase-TRUNK-security #182 (See [https://builds.apache.org/job/HBase-TRUNK-security/182/])
HBASE-5857 RIT map in RS not getting cleared while region opening (Revision 1329470)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259649#comment-13259649 ]
stack commented on HBASE-5857:
------------------------------
@Chinna Good find. Nice use of Mockito Whitebox too. Does your test confirm the fix though? Maybe I'm not reading it right. Should it check the regionserver instance does not have the test region in its this.regionsInTransitionInRS Map? Thanks.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5857:
-------------------------
Status: Patch Available (was: Open)
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5857:
-------------------------
Attachment: HBASE-5857_trunk.1.patch
Retry against hadoopqa
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5857:
-------------------------
Fix Version/s: (was: 0.92.2)
NOT applied to 0.92, just to 0.94 and trunk. Patch doesn't cleanly apply on 0.92.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5857:
-------------------------
Status: Open (was: Patch Available)
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259495#comment-13259495 ]
Chinna Rao Lalam commented on HBASE-5857:
-----------------------------------------
I will upload the patch with test case if test case is possible.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260146#comment-13260146 ]
Hudson commented on HBASE-5857:
-------------------------------
Integrated in HBase-0.92 #385 (See [https://builds.apache.org/job/HBase-0.92/385/])
HBASE-5857 RIT map in RS not getting cleared while region opening (Chinna Rao) (Revision 1329510)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268878#comment-13268878 ]
Hudson commented on HBASE-5857:
-------------------------------
Integrated in HBase-0.92-security #106 (See [https://builds.apache.org/job/HBase-0.92-security/106/])
HBASE-5857 RIT map in RS not getting cleared while region opening (Chinna Rao) (Revision 1329510)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5857:
------------------------------
Fix Version/s: 0.92.2
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259813#comment-13259813 ]
Uma Maheswara Rao G commented on HBASE-5857:
--------------------------------------------
Chinna, if you still retain this testcode in your next patch, please take care of this comments.
1) {code}
try {
+ regionServer.openRegion(REGIONINFO);
+ } catch (RegionAlreadyInTransitionException e) {
+ fail("It should not throw this exception " + e);
+ }
{code}
you need not catch the exception explicitely. Let the test fail with this exception.
Javadoc of your test should say about the expectation of your test.
2) {code}
try {
+ regionServer.openRegion(REGIONINFO);
+ fail("It should throw IOException ");
+ } catch (Exception e) {
+ }
{code}
It would great if we catch the IOException, instead of Exception.
3)Also unnecessary empty line in patch.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259497#comment-13259497 ]
ramkrishna.s.vasudevan commented on HBASE-5857:
-----------------------------------------------
Yes.. Good one. we can try writing a test case.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5857:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Applied to 0.92, 0.94, and to trunk. Thanks for the patch Chinna.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinna Rao Lalam updated HBASE-5857:
------------------------------------
Attachment: HBASE-5857_trunk.patch
HBASE-5857_94.patch
HBASE-5857_0.92.patch
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259661#comment-13259661 ]
Hadoop QA commented on HBASE-5857:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523796/HBASE-5857_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1607//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1607//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1607//console
This message is automatically generated.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259970#comment-13259970 ]
Hadoop QA commented on HBASE-5857:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523864/HBASE-5857_trunk.1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestProcessBasedCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1616//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1616//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1616//console
This message is automatically generated.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5857:
---------------------------------
Fix Version/s: (was: 0.94.1)
0.94.0
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.2.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared
while region opening
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259932#comment-13259932 ]
stack commented on HBASE-5857:
------------------------------
+1 on patch. Formatting is off but we can fix on commit. Will wait on next hadoopqa run to see if previous failure real.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.1.patch, HBASE-5857_0.92.patch, HBASE-5857_0.94.1.patch, HBASE-5857_94.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.1.patch, HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to regionsInTransitionInRS if tableDescriptors.get() throws exception the region wont be cleared from regionsInTransitionInRS. So next time if it tries to open the region in the same RS it will throw the RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira