[GitHub] [skywalking-java] lujiajing1126 commented on a diff in pull request #444: Add plugin for Spring 6, set development baseline to JDK 17, remove Powermock entirely

["lujiajing1126 (via GitHub)" <gi...@apache.org>]

lujiajing1126 commented on code in PR #444:
URL: https://github.com/apache/skywalking-java/pull/444#discussion_r1091504830


##########
pom.xml:
##########
@@ -345,24 +361,28 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>${maven-compiler-plugin.version}</version>
                 <configuration>
-                    <source>${compiler.version}</source>
+                    <source>

Review Comment:
   For JDK17, as I understand we should switch to `--release` argument of `javac` instead of keep using `source` and `target`. This can give us better guarantee of backward-compatibility with such cross-compilation.
   
   - https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
   - https://stackoverflow.com/questions/43102787/what-is-the-release-flag-in-the-java-9-compiler/43103038#43103038
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org