You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/01 10:17:18 UTC
[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #1019: MINIFICPP-1517 - Fix script engine integration test log cluttering
hunyadi-dev opened a new pull request #1019:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1019
Currently integration tests used to produce errors like these logged due to `ScriptEngine` issues:
```
[warning] Cannot load SentimentAnalysis because of ModuleNotFoundError: No module named 'vaderSentiment'
```
For the time of building the integration test docker image, we should disable scripting. This is to be reenabled when the `ScriptEngine` issue is fixed or when there is an explicit need for it in the integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1019: MINIFICPP-1517 - Fix script engine integration test log cluttering
Posted by GitBox <gi...@apache.org>.
hunyadi-dev commented on a change in pull request #1019:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1019#discussion_r584666805
##########
File path: docker/Dockerfile
##########
@@ -115,6 +115,7 @@ ARG DISABLE_LIBARCHIVE
ARG DISABLE_LZMA
ARG DISABLE_BZIP2
ARG DISABLE_SCRIPTING
+ARG DISABLE_PYTHON_SCRIPTING
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1019: MINIFICPP-1517 - Fix script engine integration test log cluttering
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #1019:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1019: MINIFICPP-1517 - Fix script engine integration test log cluttering
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1019:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1019#discussion_r584612301
##########
File path: docker/Dockerfile
##########
@@ -115,6 +115,7 @@ ARG DISABLE_LIBARCHIVE
ARG DISABLE_LZMA
ARG DISABLE_BZIP2
ARG DISABLE_SCRIPTING
+ARG DISABLE_PYTHON_SCRIPTING
Review comment:
DockerBuild.sh and DockerConfig.cmake should be updated as well to pass this parameter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org