[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5902: Instance API to directly updateTags

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5902:
URL: https://github.com/apache/incubator-pinot/pull/5902#discussion_r483211703



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/ControllerRequestURLBuilder.java
##########
@@ -53,6 +55,10 @@ public String forInstance(String instanceName) {
     return StringUtil.join("/", _baseUrl, "instances", instanceName);
   }
 
+  public String forInstanceUpdateTags(String instanceName, List<String> tags) {
+    return StringUtil.join("/", _baseUrl, "instances", instanceName, "updateTags?tags=" + Joiner.on(",").join(tags));

Review comment:
       Suggest using StringUtils to join
   ```suggestion
       return StringUtil.join("/", _baseUrl, "instances", instanceName, "updateTags?tags=" + StringUtils.join(tags, ',');
   ```

##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/ControllerRequestURLBuilder.java
##########
@@ -18,6 +18,8 @@
  */
 package org.apache.pinot.controller.helix;
 
+import com.google.common.base.Joiner;
+import java.util.List;
 import javax.annotation.Nullable;
 import org.apache.commons.lang.StringUtils;

Review comment:
       Not from this PR, but let's change it to `lang3` for consistency
   ```suggestion
   import org.apache.commons.lang3.StringUtils;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org