You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2024/03/25 08:34:46 UTC
[PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
mrhhsg opened a new pull request, #32771:
URL: https://github.com/apache/doris/pull/32771
## Proposed changes
pick #32374
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32771:
URL: https://github.com/apache/doris/pull/32771#issuecomment-2017467767
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32771:
URL: https://github.com/apache/doris/pull/32771#issuecomment-2017504638
<details>
<summary>TPC-H: <b>Total hot run time: 50221 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78184dc360544347e202528b4fdfb8647bcb8765, data reload: false
------ Round 1 ----------------------------------
q1 18225 4467 4392 4392
q2 2022 150 141 141
q3 10335 1896 1992 1896
q4 10119 1266 1332 1266
q5 8791 4098 4014 4014
q6 227 123 123 123
q7 2053 1623 1589 1589
q8 9299 2724 2731 2724
q9 10750 10666 10554 10554
q10 8838 3524 3497 3497
q11 418 239 232 232
q12 464 304 297 297
q13 18359 3967 4052 3967
q14 346 325 335 325
q15 508 464 457 457
q16 727 597 583 583
q17 1138 991 982 982
q18 7262 6912 6924 6912
q19 1666 1533 1450 1450
q20 511 309 318 309
q21 4423 4108 4109 4108
q22 514 407 403 403
Total cold run time: 116995 ms
Total hot run time: 50221 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4351 4305 4274 4274
q2 323 220 225 220
q3 4179 4126 4186 4126
q4 2780 2748 2744 2744
q5 7293 7219 7265 7219
q6 235 118 118 118
q7 3253 2903 2868 2868
q8 4335 4448 4492 4448
q9 17038 17074 17027 17027
q10 4255 4328 4307 4307
q11 763 702 694 694
q12 1019 836 850 836
q13 7465 3742 3761 3742
q14 446 422 427 422
q15 498 462 459 459
q16 761 711 701 701
q17 3842 3833 3805 3805
q18 8916 8840 8881 8840
q19 1719 1720 1640 1640
q20 2401 2155 2128 2128
q21 8608 8599 8591 8591
q22 1048 928 971 928
Total cold run time: 85528 ms
Total hot run time: 80137 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #32771:
URL: https://github.com/apache/doris/pull/32771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32771:
URL: https://github.com/apache/doris/pull/32771#issuecomment-2017525842
<details>
<summary>TPC-DS: <b>Total hot run time: 201746 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78184dc360544347e202528b4fdfb8647bcb8765, data reload: false
query1 924 399 386 386
query2 6520 2365 2190 2190
query3 6925 206 200 200
query4 20165 17906 17933 17906
query5 19707 6505 6508 6505
query6 287 213 229 213
query7 4165 303 298 298
query8 257 219 234 219
query9 3123 2662 2605 2605
query10 420 294 299 294
query11 11228 10701 10674 10674
query12 126 77 73 73
query13 5584 668 640 640
query14 17559 13533 13679 13533
query15 375 244 233 233
query16 6473 278 264 264
query17 1697 1479 855 855
query18 2331 407 406 406
query19 204 139 138 138
query20 81 75 77 75
query21 187 97 94 94
query22 5305 4958 4940 4940
query23 32790 31938 31754 31754
query24 6980 6457 6516 6457
query25 510 437 418 418
query26 522 155 159 155
query27 1918 296 295 295
query28 6080 2264 2246 2246
query29 2850 2878 2878 2878
query30 248 162 165 162
query31 909 744 756 744
query32 64 65 58 58
query33 395 259 241 241
query34 847 478 477 477
query35 1129 926 920 920
query36 1440 1084 1239 1084
query37 85 60 62 60
query38 3126 2940 2932 2932
query39 1375 1315 1330 1315
query40 202 96 91 91
query41 35 32 32 32
query42 90 84 80 80
query43 653 573 631 573
query44 1122 744 745 744
query45 243 226 220 220
query46 1243 978 1004 978
query47 1849 1656 1771 1656
query48 965 678 666 666
query49 617 371 355 355
query50 866 594 571 571
query51 4782 4671 4626 4626
query52 85 76 80 76
query53 446 322 312 312
query54 2637 2472 2462 2462
query55 83 75 81 75
query56 216 205 206 205
query57 1167 1099 1080 1080
query58 216 203 201 201
query59 3360 3318 3304 3304
query60 222 186 200 186
query61 82 83 81 81
query62 819 481 514 481
query63 467 336 332 332
query64 2538 1452 1426 1426
query65 3636 3567 3547 3547
query66 783 376 362 362
query67 17061 15558 16086 15558
query68 5883 683 669 669
query69 548 357 368 357
query70 1451 1268 1314 1268
query71 382 312 309 309
query72 6285 3537 3432 3432
query73 713 325 316 316
query74 6229 5734 5889 5734
query75 4531 3764 3736 3736
query76 3450 1205 1230 1205
query77 560 237 249 237
query78 12412 11522 11670 11522
query79 6849 642 646 642
query80 2660 409 384 384
query81 528 232 234 232
query82 1339 101 91 91
query83 178 136 128 128
query84 242 69 71 69
query85 1382 284 276 276
query86 349 341 294 294
query87 3209 3042 3011 3011
query88 4919 2377 2366 2366
query89 384 308 293 293
query90 1701 217 203 203
query91 149 114 118 114
query92 59 52 56 52
query93 2290 566 572 566
query94 905 205 199 199
query95 1107 1062 1060 1060
query96 638 333 326 326
query97 6564 6396 6419 6396
query98 192 181 170 170
query99 2942 945 872 872
Total cold run time: 302426 ms
Total hot run time: 201746 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #32771:
URL: https://github.com/apache/doris/pull/32771#issuecomment-2017468236
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32771:
URL: https://github.com/apache/doris/pull/32771#issuecomment-2017477973
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32771:
URL: https://github.com/apache/doris/pull/32771#issuecomment-2017516426
TeamCity be ut coverage result:
Function Coverage: 37.79% (8043/21284)
Line Coverage: 29.45% (65671/222976)
Region Coverage: 28.92% (33801/116888)
Branch Coverage: 24.78% (17355/70050)
Coverage Report: http://coverage.selectdb-in.cc/coverage/78184dc360544347e202528b4fdfb8647bcb8765_78184dc360544347e202528b4fdfb8647bcb8765/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)NullSafeEqualToEqual rule only change to equal if both children are not nullable (#32374) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32771:
URL: https://github.com/apache/doris/pull/32771#issuecomment-2017531560
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 78184dc360544347e202528b4fdfb8647bcb8765 with default session variables
Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 22.5 seconds inserted 10000000 Rows, about 444K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org