You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@milagro.apache.org by "kealan (via GitHub)" <gi...@apache.org> on 2023/02/28 09:53:25 UTC

[GitHub] [incubator-milagro-crypto-c] kealan opened a new issue, #113: Use the OS CSPRNG to generate random bytes when using Linux

kealan opened a new issue, #113:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/113

   ## Goal
   
   It should be an option to either use the Milagro CSPRNG or to use the
   one provided by the OS.
   
   The API should not change when using the OS CSPRNG
   
   ## Resources
   
   [getrandom](https://man7.org/linux/man-pages/man2/getrandom.2.html) should be
   used.
   
   ## Acceptance criteria
   
   1. Code is commented
   2. Tests pass
   3. Tests pass with more than 80% test coverage
   4. Static analysis should pass
   5. Code should be reviewed by two engineers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #113: Use the OS CSPRNG to generate random bytes when using Linux

Posted by "giorgiozoppi (via GitHub)" <gi...@apache.org>.
giorgiozoppi commented on issue #113:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/113#issuecomment-1484229150

   It should be also OS agnostic. For windows: https://learn.microsoft.com/en-us/windows/win32/api/bcrypt/nf-bcrypt-bcryptgenrandom?redirectedfrom=MSDN


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org

[GitHub] [incubator-milagro-crypto-c] kealan commented on issue #113: Use the OS CSPRNG to generate random bytes when using Linux

Posted by "kealan (via GitHub)" <gi...@apache.org>.
kealan commented on issue #113:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/113#issuecomment-1484624048

   Hi Gieorgio I have a simple fix in mind for Linux. Let me do that first and then you can do other OS's.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #113: Use the OS CSPRNG to generate random bytes when using Linux

Posted by "giorgiozoppi (via GitHub)" <gi...@apache.org>.
giorgiozoppi commented on issue #113:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/113#issuecomment-1484229249

   I can do that. Or have you already the code for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org