You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 16:21:57 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13275: ARROW-16546: [Parquet][C++][Python] Make Thrift limits configurable

pitrou commented on code in PR #13275:
URL: https://github.com/apache/arrow/pull/13275#discussion_r885842956


##########
cpp/src/parquet/metadata.h:
##########
@@ -126,6 +126,12 @@ class PARQUET_EXPORT ColumnChunkMetaData {
       const ApplicationVersion* writer_version = NULLPTR, int16_t row_group_ordinal = -1,
       int16_t column_ordinal = -1,
       std::shared_ptr<InternalFileDecryptor> file_decryptor = NULLPTR);

Review Comment:
   I kept the old `*MetaData::Make` signatures for compatibility, but perhaps that's not important? @emkornfield @lidavidm 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org