You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/24 09:13:11 UTC

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #171: [FLINK-28068] Introduce MemoryPoolFactory to share and preempt memory for multiple writers

JingsongLi commented on code in PR #171:
URL: https://github.com/apache/flink-table-store/pull/171#discussion_r905877682


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeOptions.java:
##########
@@ -95,7 +95,7 @@ public class MergeTreeOptions {
 
     public final long writeBufferSize;
 
-    public final long pageSize;
+    public final int pageSize;

Review Comment:
   In Flink, `pageSize` in `MemoryManager.create` is int. Int is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org