You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/23 22:36:47 UTC

[GitHub] [tvm] denise-k opened a new issue #9096: [CLEANUP] Clean up existing structural tests when structural testing infrastructure is created

denise-k opened a new issue #9096:
URL: https://github.com/apache/tvm/issues/9096


   Recently, there have been some discussions around creating infrastructure for structural tests, which test for the structure of the generated code rather than correctness of the output. This is currently on the backlog. Once the infrastructure is in place, there are places where structural tests exist in the code already which should be refactored to be more readable/cleaner.
   
   Here's an initial list (to be edited over time):
   
   - [ ] In `tests/python/relay/aot/test_crt_aot.py`: `test_aot_codegen_backend_alloc_workspace_calls`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] areusch commented on issue #9096: [CLEANUP] Clean up existing structural tests when structural testing infrastructure is created

Posted by GitBox <gi...@apache.org>.
areusch commented on issue #9096:
URL: https://github.com/apache/tvm/issues/9096#issuecomment-928190389


   In particular it would be great to create test-utils which allow someone to traverse TIR and find nodes e.g. similar to XPath so that it's easy to assert that a pass adds/removes various attrs from all instances of a particular node type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] areusch commented on issue #9096: [CLEANUP] Clean up existing structural tests when structural testing infrastructure is created

Posted by GitBox <gi...@apache.org>.
areusch commented on issue #9096:
URL: https://github.com/apache/tvm/issues/9096#issuecomment-928190389


   In particular it would be great to create test-utils which allow someone to traverse TIR and find nodes e.g. similar to XPath so that it's easy to assert that a pass adds/removes various attrs from all instances of a particular node type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org