[jira] Issue Comment Edited: (THRIFT-71) Debian packaging for thrift

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672344#action_12672344 ] 

tlipcon edited comment on THRIFT-71 at 2/10/09 10:26 AM:
-------------------------------------------------------------

Couple more thoughts upon trying to build:

  - The python-all-dbg build depend doesn't seem to exist for etch - it's new in lenny/sid. Removing it causes issues building the libthrift-python-dbg package of course. Not sure what the best course of action is here.

  - Good point on erlang-nox. The build-depend on erlang-base should also be erlang-nox then, since erlang-base-hipe is a valid alternative. Or, we could do erlang-base | erlang-base-hipe. I'm not sure exactly what the dependency structure looks like here and how dpkg satisfies them, but you seem to have a much better grasp than I do :)

  - Confirmed that openjdk-6-jdk is too specific of a depend above - I don't have that package, but use sun-java6-jdk instead. Doing the | approach seems fine as you suggested.

  - EDITED: had a csharp problem here, but looks like that's just THRIFT-309. Had a race condition with Esteve telling me about it ;-)

I'd like to say we should just drop etch support, but unfortunately Amie Street (and i'm guessing some others) are still deploying on it, so it's a blocker for adopting this deb.

-Todd

      was (Author: tlipcon):
    Couple more thoughts upon trying to build:

  - The python-all-dbg build depend doesn't seem to exist for etch - it's new in lenny/sid. Removing it causes issues building the libthrift-python-dbg package of course. Not sure what the best course of action is here.

  - Good point on erlang-nox. The build-depend on erlang-base should also be erlang-nox then, since erlang-base-hipe is a valid alternative. Or, we could do erlang-base | erlang-base-hipe. I'm not sure exactly what the dependency structure looks like here and how dpkg satisfies them, but you seem to have a much better grasp than I do :)

  - Confirmed that openjdk-6-jdk is too specific of a depend above - I don't have that package, but use sun-java6-jdk instead. Doing the | approach seems fine as you suggested.

  - Getting this error on the csharp build:

{noformat}
gmcs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library /langversion:linq
error CS1617: Invalid option `linq' for /langversion. It must be either `ISO-1' or `Default'
Compilation failed: 1 error(s), 0 warnings
{noformat}

I have never touched csharp to be honest, so not sure what this is about. I'm guessing it's etch-specific as well.

I'd like to say we should just drop etch support, but unfortunately Amie Street (and i'm guessing some others) are still deploying on it, so it's a blocker for adopting this deb.

-Todd
  
> Debian packaging for thrift
> ---------------------------
>
>                 Key: THRIFT-71
>                 URL: https://issues.apache.org/jira/browse/THRIFT-71
>             Project: Thrift
>          Issue Type: Improvement
>         Environment: debian stable (etch); probably will work on lenny, but untested
>            Reporter: Eric Anderson
>            Priority: Minor
>         Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release.  It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests.  If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.