You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/10 09:20:22 UTC

[GitHub] [spark] HyukjinKwon commented on issue #26824: [SPARK-30197][PYSPARK] Add minimum `requirements-dev.txt` file to `python` directory

HyukjinKwon commented on issue #26824: [SPARK-30197][PYSPARK] Add minimum `requirements-dev.txt` file to `python` directory
URL: https://github.com/apache/spark/pull/26824#issuecomment-563941858
 
 
   > BTW, I'll use == instead of >= since it's risky (especially for pyarrow).
   > That's the reason why this PR title is minimum instead of valid range.
   
   Hm, If that's risky, we should rather change `setup.py` version specification. I think it's kind of a convention to use latest libraries by default. See pandas one as an example (https://github.com/pandas-dev/pandas/blob/master/requirements-dev.txt).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org