You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by SidFerreira <gi...@git.apache.org> on 2015/07/28 21:55:19 UTC
[GitHub] cordova-plugin-network-information pull request: Performance-relat...
GitHub user SidFerreira opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/30
Performance-related fix
Move all conversions to line 236, saving ~14 tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SidFerreira/cordova-plugin-network-information patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit 6550b937d0d437183984437deb452cbdd653ac18
Author: Sid Ferreira <si...@ferreiraz.com.br>
Date: 2015-07-28T19:55:07Z
Performance-related fix
Move all conversions to line 236, saving ~14 tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Performance-relat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Performance-relat...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/30#issuecomment-125736123
Thanks, I am planning to remove all string comparisons one day and actually use the defined types, but this does help in the meantime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org