You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2011/01/31 01:23:58 UTC
svn commit: r1065440 -
/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/DefaultLdapCodecService.java
Author: elecharny
Date: Mon Jan 31 00:23:57 2011
New Revision: 1065440
URL: http://svn.apache.org/viewvc?rev=1065440&view=rev
Log:
The basic control decorator factory decorate() method was recreating a new control instead of decorating the one we pass as an argument
Modified:
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/DefaultLdapCodecService.java
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/DefaultLdapCodecService.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/DefaultLdapCodecService.java?rev=1065440&r1=1065439&r2=1065440&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/DefaultLdapCodecService.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/DefaultLdapCodecService.java Mon Jan 31 00:23:57 2011
@@ -234,10 +234,7 @@ public class DefaultLdapCodecService imp
if ( factory == null )
{
- org.apache.directory.shared.ldap.model.message.controls.BasicControl basic =
- new org.apache.directory.shared.ldap.model.message.controls.BasicControl( control.getOid() );
- basic.setCritical( control.isCritical() );
- return new BasicControlDecorator( this, basic );
+ return new BasicControlDecorator( this, (BasicControl)control );
}
return factory.decorate( control );