You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/05/09 23:49:31 UTC
Review Request 21288: Allowed to get/set MTU for a link.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Bugs: MESOS-1228
https://issues.apache.org/jira/browse/MESOS-1228
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/linux/routing/link/link.hpp PRE-CREATION
src/linux/routing/link/link.cpp PRE-CREATION
src/tests/routing_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21288/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/
-----------------------------------------------------------
(Updated May 15, 2014, 12:42 a.m.)
Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Rebased.
Bugs: MESOS-1228
https://issues.apache.org/jira/browse/MESOS-1228
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/linux/routing/link/link.hpp PRE-CREATION
src/linux/routing/link/link.cpp PRE-CREATION
src/tests/routing_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21288/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/
-----------------------------------------------------------
(Updated May 14, 2014, 10:10 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Review comments. Rebased.
Bugs: MESOS-1228
https://issues.apache.org/jira/browse/MESOS-1228
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/linux/routing/link/link.hpp PRE-CREATION
src/linux/routing/link/link.cpp PRE-CREATION
src/tests/routing_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21288/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Jie Yu <yu...@gmail.com>.
> On May 13, 2014, 9:41 p.m., Dominic Hamon wrote:
> > src/linux/routing/link/link.hpp, line 82
> > <https://reviews.apache.org/r/21288/diff/2/?file=579306#file579306line82>
> >
> > MTU or getMTU to match setMTU below.
Dominic, I choose not to do that for now as it requires too much changes to the depending patches. Also, we use mac() and setMAC(), so I'd like to be consistent for this patch. I may want to do a cleanup to fix all these names to be:
getIP() and setIP() (currently, it is ip() and setIP())
getMAC() and setMAC() (currently, it is mac() and setMAC())
getMTU() and setMTU() (currently, it is mtu() and setMTU())
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/#review42893
-----------------------------------------------------------
On May 13, 2014, 12:34 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21288/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 12:34 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.hpp PRE-CREATION
> src/linux/routing/link/link.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/#review42893
-----------------------------------------------------------
src/linux/routing/link/link.hpp
<https://reviews.apache.org/r/21288/#comment76813>
MTU or getMTU to match setMTU below.
- Dominic Hamon
On May 12, 2014, 5:34 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21288/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 5:34 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.hpp PRE-CREATION
> src/linux/routing/link/link.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/
-----------------------------------------------------------
(Updated May 13, 2014, 12:34 a.m.)
Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Review comments.
Bugs: MESOS-1228
https://issues.apache.org/jira/browse/MESOS-1228
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/linux/routing/link/link.hpp PRE-CREATION
src/linux/routing/link/link.cpp PRE-CREATION
src/tests/routing_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21288/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Jie Yu <yu...@gmail.com>.
> On May 12, 2014, 10:25 p.m., Vinod Kone wrote:
> > src/tests/routing_tests.cpp, line 135
> > <https://reviews.apache.org/r/21288/diff/1/?file=577816#file577816line135>
> >
> > this is not really changing the mtu, but setting the same value. not sure if kernel handles it differently.
> >
> > would it be better to set a different value and reset it back to 'mtu' so that the test doesn't have any side-effect? just a thought.
I verified that by setting a different value, and it worked:)
I just thought it's better not have any side effect for host loopback device:) I can change it back.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/#review42761
-----------------------------------------------------------
On May 9, 2014, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21288/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:49 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.hpp PRE-CREATION
> src/linux/routing/link/link.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/#review42761
-----------------------------------------------------------
Ship it!
src/linux/routing/link/link.cpp
<https://reviews.apache.org/r/21288/#comment76645>
const
src/tests/routing_tests.cpp
<https://reviews.apache.org/r/21288/#comment76647>
this is not really changing the mtu, but setting the same value. not sure if kernel handles it differently.
would it be better to set a different value and reset it back to 'mtu' so that the test doesn't have any side-effect? just a thought.
- Vinod Kone
On May 9, 2014, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21288/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:49 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.hpp PRE-CREATION
> src/linux/routing/link/link.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Jie Yu <yu...@gmail.com>.
> On May 12, 2014, 6:02 p.m., Chi Zhang wrote:
> > src/linux/routing/link/link.hpp, line 82
> > <https://reviews.apache.org/r/21288/diff/1/?file=577814#file577814line82>
> >
> > i think mtu() is enough? like how you named link::ip() and link::mac()?
OK, to be consistent, I'll change that to mtu() and setMTU().
Also, I would like to change setMac to setMAC so that it is consistent.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/#review42716
-----------------------------------------------------------
On May 9, 2014, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21288/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:49 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.hpp PRE-CREATION
> src/linux/routing/link/link.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21288: Allowed to get/set MTU for a link.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/#review42716
-----------------------------------------------------------
src/linux/routing/link/link.hpp
<https://reviews.apache.org/r/21288/#comment76526>
i think mtu() is enough? like how you named link::ip() and link::mac()?
- Chi Zhang
On May 9, 2014, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21288/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:49 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.hpp PRE-CREATION
> src/linux/routing/link/link.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>