[jira] Commented: (HDFS-1205) FSDatasetAsyncDiskService should name its threads

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902691#action_12902691 ] 

Todd Lipcon commented on HDFS-1205:
-----------------------------------

Ran commit-tests locally and passed. No new test case included -- existing tests cover the code, and manually verified the names by jstacking the unit tests until I caught one:

todd@178:~$ jps | grep JUnit | awk '{print $1}' | xargs jstack | grep Async
"Async disk worker #0 for volume /Users/todd/dev/git/hadoop-hdfs/build/test/data/dfs/data/data5/current" daemon prio=5 tid=101a75000 nid=0x134b18000 waiting on condition [134b17000]



> FSDatasetAsyncDiskService should name its threads
> -------------------------------------------------
>
>                 Key: HDFS-1205
>                 URL: https://issues.apache.org/jira/browse/HDFS-1205
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-1205-0.20.txt, hdfs-1205.txt
>
>
> FSDatasetAsyncService creates threads but doesn't name them. The ThreadFactory should name them with the volume they work on as well as a thread index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.