[GitHub] [arrow-datafusion] Dandandan edited a comment on pull request #387: Constant fold / optimize `to_timestamp` function during planning

[GitBox <gi...@apache.org>]

Dandandan edited a comment on pull request #387:
URL: https://github.com/apache/arrow-datafusion/pull/387#issuecomment-848067209


   > > For some strange reason cargo clippy on my local doesn't throw these errors.
   > 
   > It may be related to what version of rust is used. I also have some troubles with clippy sometimes not finding errors. I run the following locally (I am somewhat embarrassed but it does work for me  )
   > 
   > ```
   > find . -name '*.rs' | grep -v target | xargs touch && cargo clippy --all --all-targets -- -D warnings
   > ```
   
   Touching the files (or cleaning the build) should not be needed anymore since 1.52 https://blog.rust-lang.org/2021/05/06/Rust-1.52.0.html
   
   > Previously, running cargo check followed by cargo clippy wouldn't actually run Clippy: the build caching in Cargo didn't differentiate between the two. In 1.52, however, this has been fixed, which means that users will get the expected behavior independent of the order in which they run the two commands.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org