You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ump45nose (via GitHub)" <gi...@apache.org> on 2026/10/18 01:06:54 UTC
[PR] fix(aws): sign default headers on list requests [arrow-rs-object-store]
ump45nose opened a new pull request, #883:
URL: https://github.com/apache/arrow-rs-object-store/pull/883
# Which issue does this PR close?
Closes #877.
# Rationale for this change
`list_request` built and signed its request without the `ClientOptions` default headers, unlike `request`, `get_request`, `bulk_delete_request` and `complete_multipart` (#636, #688). reqwest still adds the default headers when the request is sent, so they go out unsigned and S3 rejects any `x-amz-*` default header on LIST with `403 HeadersNotSigned`.
# What changes are included in this PR?
- `list_request` copies the default headers into the request before SigV4 signing, the same way the other request paths do.
- New test `test_default_headers_signed_list_request`. It records the request headers and checks them after the call returns, because `MockServer` swallows a panic raised inside its handler. It fails on `main` and passes with this change.
# Are there any user-facing changes?
S3 list requests now carry and sign the configured default headers. No API changes.
I used an AI coding assistant to help write this change and the test. I reviewed the diff and ran the `aws` tests and clippy locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(aws): sign default headers on list requests [arrow-rs-object-store]
Posted by "alamb (via GitHub) via github" <gi...@arrow.apache.org>.
alamb commented on PR #883:
URL: https://github.com/apache/arrow-rs-object-store/pull/883#issuecomment-6558308354
Thank you for the contribution. The change may well be correct, but I am closing this PR under the arrow-rs guidance on AI generated submissions: https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#ai-generated-submissions
Maintainer review time is the scarcest resource in this project. This account has opened more than 860 PRs across many repositories since October 1, and similar PRs from it have already been closed in apache/datafusion under the AI policy. We have not seen clear human engagement on these PRs (for example, replies are marked as AI-assisted). That suggests the changes aren't coming from someone who uses object_store, and that no human will be around to discuss review feedback and maintain the code. Reviewing PRs like this costs us more time than it saves.
If you do use object_store and this fix matters to you, please pick the one change you care most about. Then open a focused PR with a short description in your own words, one you have reviewed and understand, and we'd be happy to help with review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(aws): sign default headers on list requests [arrow-rs-object-store]
Posted by "alamb (via GitHub) via github" <gi...@arrow.apache.org>.
alamb closed pull request #883: fix(aws): sign default headers on list requests
URL: https://github.com/apache/arrow-rs-object-store/pull/883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org