You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/05/24 03:03:00 UTC
[GitHub] [cordova-plugin-media] erisu opened a new pull request, #344: feat(android): drop WRITE_EXTERNAL_STORAGE permission
erisu opened a new pull request, #344:
URL: https://github.com/apache/cordova-plugin-media/pull/344
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Drop the `WRITE_EXTERNAL_STORAGE` permission declaration since its **protection level** is **dangerous**.
Closes #316
### Description
<!-- Describe your changes in detail -->
Removed the `WRITE_EXTERNAL_STORAGE` permission declare from `plugin.xml`
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media] breautek commented on a diff in pull request #344: feat(android): drop WRITE_EXTERNAL_STORAGE permission
Posted by GitBox <gi...@apache.org>.
breautek commented on code in PR #344:
URL: https://github.com/apache/cordova-plugin-media/pull/344#discussion_r880425466
##########
README.md:
##########
@@ -50,6 +50,28 @@ function onDeviceReady() {
cordova plugin add cordova-plugin-media
```
+### Android Permission Quirks
+
+**[WRITE_EXTERNAL_STORAGE](https://developer.android.com/reference/android/Manifest.permission#WRITE_EXTERNAL_STORAGE)**
+
+By default, this plugin no longer enables the `WRITE_EXTERNAL_STORE` permission because the permission's protection level is set to dangerous.
+
+This permission is not required for writing to the application-specific external directories.
+
+If you are trying to write to external directories that are not owned by the application, you might need to enable this permission.
Review Comment:
I don't think this is correct and will probably mislead users down the wrong path.
As of API 30 target, which cordova-android@10 does by default, `WRITE_EXTERNAL_STORAGE` does nothing.
See https://developer.android.com/about/versions/11/privacy/storage#permissions-target-11
> If your app targets Android 11, both the WRITE_EXTERNAL_STORAGE permission and the WRITE_MEDIA_STORAGE privileged permission no longer provide any additional access.
If they are targeting a lower SDK, which is not something we generally support, then they may require the write permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media] erisu commented on a diff in pull request #344: feat(android): drop WRITE_EXTERNAL_STORAGE permission
Posted by GitBox <gi...@apache.org>.
erisu commented on code in PR #344:
URL: https://github.com/apache/cordova-plugin-media/pull/344#discussion_r880513519
##########
README.md:
##########
@@ -50,6 +50,28 @@ function onDeviceReady() {
cordova plugin add cordova-plugin-media
```
+### Android Permission Quirks
+
+**[WRITE_EXTERNAL_STORAGE](https://developer.android.com/reference/android/Manifest.permission#WRITE_EXTERNAL_STORAGE)**
+
+By default, this plugin no longer enables the `WRITE_EXTERNAL_STORE` permission because the permission's protection level is set to dangerous.
+
+This permission is not required for writing to the application-specific external directories.
+
+If you are trying to write to external directories that are not owned by the application, you might need to enable this permission.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media] erisu merged pull request #344: feat(android): drop WRITE_EXTERNAL_STORAGE permission
Posted by GitBox <gi...@apache.org>.
erisu merged PR #344:
URL: https://github.com/apache/cordova-plugin-media/pull/344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org