[jira] [Commented] (BIGTOP-704) Make variables used in pig build/install scripts consistent

["Bruno Mahé (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457598#comment-13457598 ] 

Bruno Mahé commented on BIGTOP-704:
-----------------------------------

Was it tested?
It looks like you forgot to update the rules file as well as the spec file.

>From the spec file:
{noformat}
sh -x %{SOURCE2} \
          --build-dir=build \
          --doc-dir=$RPM_BUILD_ROOT%{doc_pig} \
          --prefix=$RPM_BUILD_ROOT
{noformat}

"--doc-dir" should not have $RPM_BUILD_ROOT since you are now prefixing it with the prefix from within the install script.


>From the rules file:
{noformat}
	sh -x debian/install_pig.sh \
	  --build-dir=build \
	  --prefix=debian/${pig_pkg_name} \
          --doc-dir=debian/${pig_pkg_name}/usr/share/doc/${pig_pkg_name} \
          --examples-dir=debian/${pig_pkg_name}/usr/share/doc/${pig_pkg_name}/examples
{noformat}

Same here with debian/${pig_pkg_name} for --doc-dir and --examples-dir
                
> Make variables used in pig build/install scripts consistent
> -----------------------------------------------------------
>
>                 Key: BIGTOP-704
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-704
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: General
>            Reporter: Anatoli Fomenko
>            Assignee: Anatoli Fomenko
>             Fix For: 0.5.0
>
>         Attachments: BIGTOP-704.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira