You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2025/02/19 07:25:08 UTC
[PR] Use run_id to implement ti clear in API when given [airflow]
uranusjr opened a new pull request, #46883:
URL: https://github.com/apache/airflow/pull/46883
Previously, the API converts dag_run_id from the request into a start/end date pair to call the underlying Python function. This however does not work correctly if the requested DAG run has logical_date=None, resulting in both start/end dates to be set to None, and ALL DAG runs selected.
Since the underlying Python function accepts a run_id directly, we can simply pass in dag_run_id in the API implementation instead to get the correct result.
Fix #46804.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use run_id to implement ti clear in API when given [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #46883:
URL: https://github.com/apache/airflow/pull/46883#issuecomment-2668004430
This will fix the first issue, but what should `Past` or `Future` buttons in the UI do when logical date = None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use run_id to implement ti clear in API when given [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #46883:
URL: https://github.com/apache/airflow/pull/46883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use run_id to implement ti clear in API when given [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #46883:
URL: https://github.com/apache/airflow/pull/46883#issuecomment-2668026731
We should probably either disable them or make them do nothing. There’s no corresponding Python function for them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org