You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Francois Kritzinger (JIRA)" <ji...@apache.org> on 2012/10/22 16:04:14 UTC

[jira] [Created] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Francois Kritzinger created CAMEL-5731:
------------------------------------------

             Summary: Setting alphabet header to 8-bit doesn't update data coding
                 Key: CAMEL-5731
                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
             Project: Camel
          Issue Type: Bug
          Components: camel-smpp
            Reporter: Francois Kritzinger


For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.

I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.

Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Work started] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-5731 started by Christian Müller.

> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Müller closed CAMEL-5731.
-----------------------------------

    Resolution: Fixed
    
> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490041#comment-13490041 ] 

Christian Müller commented on CAMEL-5731:
-----------------------------------------

Thanks for the test case Francois. I fixed this issue.
                
> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Francois Kritzinger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francois Kritzinger updated CAMEL-5731:
---------------------------------------

    Attachment: alpha_not_updating_dcs_demo_unit_test.diff

In this test, the alphabet header is set to 8-bit, but the data coding passed to SmppSession.submitShortMessage() is 0, which is the default and does not indicate an 8-bit data coding.
                
> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-5731:
----------------------------------

    Assignee: Christian Müller
    
> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Müller updated CAMEL-5731:
------------------------------------

    Priority: Minor  (was: Major)
    
> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490039#comment-13490039 ] 

Christian Müller commented on CAMEL-5731:
-----------------------------------------

A workaround is to use the header SmppConstants.DATA_CODING. This will be taken into account.
                
> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-5731) Setting alphabet header to 8-bit doesn't update data coding

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-5731:
-------------------------------

    Fix Version/s: 2.11.0
                   2.10.3
                   2.9.5
    
> Setting alphabet header to 8-bit doesn't update data coding
> -----------------------------------------------------------
>
>                 Key: CAMEL-5731
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5731
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: alpha_not_updating_dcs_demo_unit_test.diff
>
>
> For derivatives of SmppSmCommand, setting the SmppConstants.ALPHABET header to e.g. Alphabet.ALPHA_8_BIT doesn't change the data coding of the resulting command.
> I am not 100% clear on how the alphabet header is meant to interact with the data coding, but this seems like a bug to me.
> Patch with demo unit test to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira