You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pedro Marques <pe...@gmail.com> on 2013/10/09 01:59:11 UTC
Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs
-----
client/tomcatconf/applicationContext.xml.in 0ab2515
client/tomcatconf/componentContext.xml.in 157ad5a
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 92f5eeb
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 1b7a7d8
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java 885a60f
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java 3a38020
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java c655b0b
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java 5195793
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 8a3ca1b
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java d169b37
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java acd1bed
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java bad2502
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java f9e7c24
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 4c8c2e9
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 06daf12
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 6f0ecf2
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java aa4e9d5
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java f3884fb
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java b90792c
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 9c8b61d
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java ca90666
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java 8e238fd
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java ff08560
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 7abb40a
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 7cd420c
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 4b05e96
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java f65bfc7
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 0ec7c9e
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java df40025
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 99ab944
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java 029950a
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java c3e07d0
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 87feaa9
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 55cef7c
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java a5767c6
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml 623d188
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
(Updated Oct. 16, 2013, 6:51 p.m.)
Review request for cloudstack.
Changes
-------
Diff against master branch as requested.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs (updated)
-----
api/src/com/cloud/network/Network.java 49f380b
client/pom.xml fd1f13a
client/tomcatconf/commands.properties.in 58c770d
client/tomcatconf/componentContext.xml.in df5b002
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 92fbab2
plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
plugins/pom.xml ca41dff
tools/marvin/marvin/cloudstackConnection.py c5a4c67
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
> On Oct. 9, 2013, 2:49 p.m., Murali Reddy wrote:
> > - Is there a reason why no new isolation type was not added for 'contrail controller'. For other overlay technologies (STT, GRE, VXLAN) that CloudStack support there is an isolation type and corresponding Guru that handles isolation type.
> >
> > - There is a 'EventBus' on to which all events generated by CloudStack gets published. Right approach would be to plug-in to subscribe to interested events from event bus. But the current implementation of EventBus expects external AMQP server, so it may not be ideal. EventInterceptor approach implemented in the plug-in works fine to get the notification. But enabling it by default in ApplicationContext does not seem right thing to do.
> >
> > - If you can add some more details in to the FS on deployment model it will give more perspective to reviewers
> >
> > + is the VRouter mentioned in the FS is a appliance provisioned by CloudStack for each guest network by servicemanager? Or its a logical router on the dataplane that does the forwarding?
> > + is BGP/MPLS required on the IP fabric and the Hypervisors
> >
>
> Pedro Marques wrote:
> Murali,
> We didn't add a new isolation type to avoid changing the CloudStack code. The current define describes the encapsulation technology. Contrail can use several encapsulation technologies: MPLS/GRE, MPLS/UDP, MPLS over VXLAN header. I can add one if you find it helpful... from a technology perspective contrail focus on the control plane solution rather than the encapsulation.
>
> The event bus doesn't look like an attractive approach. If the ActionEvent listeners will cause a problem we can periodically poll from the plugin.
>
> The "VRouter" is a linux kernel module running on each Host. BGP/MPLS is a control plane technology. The fabric is required to be able to transport IP packets between Hosts... No other assumption is made; no need for VLANs or MPLS on the fabric.
>
>
> Murali Reddy wrote:
> Pedro,
>
> Thanks for clarification. Now I understand that Contrial being control plane solution and its ability support multiple encapsulation technologies. Actually my earlier comment was not so much about isolation method (CloudStack notion of overlay/encapsulation technologies). Currently there is no prescriptive way for CloudStack networking to know which NetworkGuru should be handling the network design, so it just loops through all network guru to implement & design the network. Unfortunately, its network guru to know if it should handle the design/implement call etc for a network. For e.g. VxlanGuestNetworkGuru thinks its authoritative to handle the isolation method 'VXLAN'. If ContrailGuru thinks it can handle VXLAN then there is conflict if both the plug-ins are enabled by default in the componentContext. It should not be plug-in developers problem, but i want to suggest to add a safe-guard. Either add new isolation method (like MIDO for e.g for Midokura) and let Contrail Guru a
nd Element to handle only if isolation method is for Contrail.
>
> I agree that event bus approach is not attractive with current RabbitMq implementation. What my intention was new interceptor (contrailEventInterceptor) be enabled only if some one wants to use Contrail plug-in. If Contrial plug-in is not used then interceptor is just adding additional overhead. You can make this step (of configuring interceptor in applicationContext as setup step).
>
Murali,
My understanding is that there are two mechanisms in play when it comes to identifying the Guru: the encapsulation and whether an offering is enabled on the physical network attached to the zone. The contrail plugin looks at the later in order to allow the user to have multiple zones with different network offerings.
I agree that the contrail event interceptor should be enabled only if you want to use the plugin. I'll revert the applicationContext.xml.in change.
Is it possible for you to accept this diff into the contrail branch ?
My understanding from Chip is that what we where trying to do is to incrementally get the branch to a stage where it can be merged... it would be easier to do that as a set of commits into the branch.
- Pedro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review26819
-----------------------------------------------------------
On Oct. 8, 2013, 11:58 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 0ab2515
> client/tomcatconf/componentContext.xml.in 157ad5a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 92f5eeb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 1b7a7d8
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java 885a60f
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java 3a38020
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java c655b0b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java 5195793
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 8a3ca1b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java d169b37
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java acd1bed
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java bad2502
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java f9e7c24
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 4c8c2e9
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 06daf12
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 6f0ecf2
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java aa4e9d5
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java f3884fb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java b90792c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 9c8b61d
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java ca90666
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java 8e238fd
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java ff08560
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 7abb40a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 7cd420c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 4b05e96
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java f65bfc7
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 0ec7c9e
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java df40025
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 99ab944
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java 029950a
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java c3e07d0
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 87feaa9
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 55cef7c
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java a5767c6
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml 623d188
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Murali Reddy <mu...@gmail.com>.
> On Oct. 9, 2013, 2:49 p.m., Murali Reddy wrote:
> > - Is there a reason why no new isolation type was not added for 'contrail controller'. For other overlay technologies (STT, GRE, VXLAN) that CloudStack support there is an isolation type and corresponding Guru that handles isolation type.
> >
> > - There is a 'EventBus' on to which all events generated by CloudStack gets published. Right approach would be to plug-in to subscribe to interested events from event bus. But the current implementation of EventBus expects external AMQP server, so it may not be ideal. EventInterceptor approach implemented in the plug-in works fine to get the notification. But enabling it by default in ApplicationContext does not seem right thing to do.
> >
> > - If you can add some more details in to the FS on deployment model it will give more perspective to reviewers
> >
> > + is the VRouter mentioned in the FS is a appliance provisioned by CloudStack for each guest network by servicemanager? Or its a logical router on the dataplane that does the forwarding?
> > + is BGP/MPLS required on the IP fabric and the Hypervisors
> >
>
> Pedro Marques wrote:
> Murali,
> We didn't add a new isolation type to avoid changing the CloudStack code. The current define describes the encapsulation technology. Contrail can use several encapsulation technologies: MPLS/GRE, MPLS/UDP, MPLS over VXLAN header. I can add one if you find it helpful... from a technology perspective contrail focus on the control plane solution rather than the encapsulation.
>
> The event bus doesn't look like an attractive approach. If the ActionEvent listeners will cause a problem we can periodically poll from the plugin.
>
> The "VRouter" is a linux kernel module running on each Host. BGP/MPLS is a control plane technology. The fabric is required to be able to transport IP packets between Hosts... No other assumption is made; no need for VLANs or MPLS on the fabric.
>
>
> Murali Reddy wrote:
> Pedro,
>
> Thanks for clarification. Now I understand that Contrial being control plane solution and its ability support multiple encapsulation technologies. Actually my earlier comment was not so much about isolation method (CloudStack notion of overlay/encapsulation technologies). Currently there is no prescriptive way for CloudStack networking to know which NetworkGuru should be handling the network design, so it just loops through all network guru to implement & design the network. Unfortunately, its network guru to know if it should handle the design/implement call etc for a network. For e.g. VxlanGuestNetworkGuru thinks its authoritative to handle the isolation method 'VXLAN'. If ContrailGuru thinks it can handle VXLAN then there is conflict if both the plug-ins are enabled by default in the componentContext. It should not be plug-in developers problem, but i want to suggest to add a safe-guard. Either add new isolation method (like MIDO for e.g for Midokura) and let Contrail Guru a
nd Element to handle only if isolation method is for Contrail.
>
> I agree that event bus approach is not attractive with current RabbitMq implementation. What my intention was new interceptor (contrailEventInterceptor) be enabled only if some one wants to use Contrail plug-in. If Contrial plug-in is not used then interceptor is just adding additional overhead. You can make this step (of configuring interceptor in applicationContext as setup step).
>
>
> Pedro Marques wrote:
> Murali,
> My understanding is that there are two mechanisms in play when it comes to identifying the Guru: the encapsulation and whether an offering is enabled on the physical network attached to the zone. The contrail plugin looks at the later in order to allow the user to have multiple zones with different network offerings.
>
> I agree that the contrail event interceptor should be enabled only if you want to use the plugin. I'll revert the applicationContext.xml.in change.
> Is it possible for you to accept this diff into the contrail branch ?
> My understanding from Chip is that what we where trying to do is to incrementally get the branch to a stage where it can be merged... it would be easier to do that as a set of commits into the branch.
Your understanding is right. Sorry if i have missed, but i did not see any check to see if 'Connectivity' service provider in the network offering is 'Provider.JuniperContrail' while performing network operations.
Patch is self-contained, should be easy to merge. But i am not able to apply the current patch to master (possibly due to references to deleted files). Can you please submit new patch that applies cleanly to master. Except for the comments i have, all integration points with core is fine. If no one else has further comments i can apply patch to master.
- Murali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review26819
-----------------------------------------------------------
On Oct. 8, 2013, 11:58 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 0ab2515
> client/tomcatconf/componentContext.xml.in 157ad5a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 92f5eeb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 1b7a7d8
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java 885a60f
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java 3a38020
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java c655b0b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java 5195793
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 8a3ca1b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java d169b37
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java acd1bed
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java bad2502
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java f9e7c24
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 4c8c2e9
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 06daf12
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 6f0ecf2
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java aa4e9d5
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java f3884fb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java b90792c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 9c8b61d
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java ca90666
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java 8e238fd
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java ff08560
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 7abb40a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 7cd420c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 4b05e96
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java f65bfc7
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 0ec7c9e
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java df40025
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 99ab944
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java 029950a
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java c3e07d0
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 87feaa9
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 55cef7c
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java a5767c6
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml 623d188
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
> On Oct. 9, 2013, 2:49 p.m., Murali Reddy wrote:
> > - Is there a reason why no new isolation type was not added for 'contrail controller'. For other overlay technologies (STT, GRE, VXLAN) that CloudStack support there is an isolation type and corresponding Guru that handles isolation type.
> >
> > - There is a 'EventBus' on to which all events generated by CloudStack gets published. Right approach would be to plug-in to subscribe to interested events from event bus. But the current implementation of EventBus expects external AMQP server, so it may not be ideal. EventInterceptor approach implemented in the plug-in works fine to get the notification. But enabling it by default in ApplicationContext does not seem right thing to do.
> >
> > - If you can add some more details in to the FS on deployment model it will give more perspective to reviewers
> >
> > + is the VRouter mentioned in the FS is a appliance provisioned by CloudStack for each guest network by servicemanager? Or its a logical router on the dataplane that does the forwarding?
> > + is BGP/MPLS required on the IP fabric and the Hypervisors
> >
Murali,
We didn't add a new isolation type to avoid changing the CloudStack code. The current define describes the encapsulation technology. Contrail can use several encapsulation technologies: MPLS/GRE, MPLS/UDP, MPLS over VXLAN header. I can add one if you find it helpful... from a technology perspective contrail focus on the control plane solution rather than the encapsulation.
The event bus doesn't look like an attractive approach. If the ActionEvent listeners will cause a problem we can periodically poll from the plugin.
The "VRouter" is a linux kernel module running on each Host. BGP/MPLS is a control plane technology. The fabric is required to be able to transport IP packets between Hosts... No other assumption is made; no need for VLANs or MPLS on the fabric.
- Pedro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review26819
-----------------------------------------------------------
On Oct. 8, 2013, 11:58 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 0ab2515
> client/tomcatconf/componentContext.xml.in 157ad5a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 92f5eeb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 1b7a7d8
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java 885a60f
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java 3a38020
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java c655b0b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java 5195793
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 8a3ca1b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java d169b37
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java acd1bed
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java bad2502
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java f9e7c24
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 4c8c2e9
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 06daf12
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 6f0ecf2
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java aa4e9d5
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java f3884fb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java b90792c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 9c8b61d
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java ca90666
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java 8e238fd
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java ff08560
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 7abb40a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 7cd420c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 4b05e96
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java f65bfc7
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 0ec7c9e
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java df40025
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 99ab944
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java 029950a
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java c3e07d0
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 87feaa9
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 55cef7c
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java a5767c6
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml 623d188
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Murali Reddy <mu...@gmail.com>.
> On Oct. 9, 2013, 2:49 p.m., Murali Reddy wrote:
> > - Is there a reason why no new isolation type was not added for 'contrail controller'. For other overlay technologies (STT, GRE, VXLAN) that CloudStack support there is an isolation type and corresponding Guru that handles isolation type.
> >
> > - There is a 'EventBus' on to which all events generated by CloudStack gets published. Right approach would be to plug-in to subscribe to interested events from event bus. But the current implementation of EventBus expects external AMQP server, so it may not be ideal. EventInterceptor approach implemented in the plug-in works fine to get the notification. But enabling it by default in ApplicationContext does not seem right thing to do.
> >
> > - If you can add some more details in to the FS on deployment model it will give more perspective to reviewers
> >
> > + is the VRouter mentioned in the FS is a appliance provisioned by CloudStack for each guest network by servicemanager? Or its a logical router on the dataplane that does the forwarding?
> > + is BGP/MPLS required on the IP fabric and the Hypervisors
> >
>
> Pedro Marques wrote:
> Murali,
> We didn't add a new isolation type to avoid changing the CloudStack code. The current define describes the encapsulation technology. Contrail can use several encapsulation technologies: MPLS/GRE, MPLS/UDP, MPLS over VXLAN header. I can add one if you find it helpful... from a technology perspective contrail focus on the control plane solution rather than the encapsulation.
>
> The event bus doesn't look like an attractive approach. If the ActionEvent listeners will cause a problem we can periodically poll from the plugin.
>
> The "VRouter" is a linux kernel module running on each Host. BGP/MPLS is a control plane technology. The fabric is required to be able to transport IP packets between Hosts... No other assumption is made; no need for VLANs or MPLS on the fabric.
>
Pedro,
Thanks for clarification. Now I understand that Contrial being control plane solution and its ability support multiple encapsulation technologies. Actually my earlier comment was not so much about isolation method (CloudStack notion of overlay/encapsulation technologies). Currently there is no prescriptive way for CloudStack networking to know which NetworkGuru should be handling the network design, so it just loops through all network guru to implement & design the network. Unfortunately, its network guru to know if it should handle the design/implement call etc for a network. For e.g. VxlanGuestNetworkGuru thinks its authoritative to handle the isolation method 'VXLAN'. If ContrailGuru thinks it can handle VXLAN then there is conflict if both the plug-ins are enabled by default in the componentContext. It should not be plug-in developers problem, but i want to suggest to add a safe-guard. Either add new isolation method (like MIDO for e.g for Midokura) and let Contrail Guru and Ele
ment to handle only if isolation method is for Contrail.
I agree that event bus approach is not attractive with current RabbitMq implementation. What my intention was new interceptor (contrailEventInterceptor) be enabled only if some one wants to use Contrail plug-in. If Contrial plug-in is not used then interceptor is just adding additional overhead. You can make this step (of configuring interceptor in applicationContext as setup step).
- Murali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review26819
-----------------------------------------------------------
On Oct. 8, 2013, 11:58 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 0ab2515
> client/tomcatconf/componentContext.xml.in 157ad5a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 92f5eeb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 1b7a7d8
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java 885a60f
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java 3a38020
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java c655b0b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java 5195793
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 8a3ca1b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java d169b37
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java acd1bed
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java bad2502
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java f9e7c24
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 4c8c2e9
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 06daf12
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 6f0ecf2
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java aa4e9d5
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java f3884fb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java b90792c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 9c8b61d
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java ca90666
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java 8e238fd
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java ff08560
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 7abb40a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 7cd420c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 4b05e96
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java f65bfc7
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 0ec7c9e
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java df40025
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 99ab944
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java 029950a
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java c3e07d0
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 87feaa9
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 55cef7c
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java a5767c6
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml 623d188
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review26819
-----------------------------------------------------------
- Is there a reason why no new isolation type was not added for 'contrail controller'. For other overlay technologies (STT, GRE, VXLAN) that CloudStack support there is an isolation type and corresponding Guru that handles isolation type.
- There is a 'EventBus' on to which all events generated by CloudStack gets published. Right approach would be to plug-in to subscribe to interested events from event bus. But the current implementation of EventBus expects external AMQP server, so it may not be ideal. EventInterceptor approach implemented in the plug-in works fine to get the notification. But enabling it by default in ApplicationContext does not seem right thing to do.
- If you can add some more details in to the FS on deployment model it will give more perspective to reviewers
+ is the VRouter mentioned in the FS is a appliance provisioned by CloudStack for each guest network by servicemanager? Or its a logical router on the dataplane that does the forwarding?
+ is BGP/MPLS required on the IP fabric and the Hypervisors
- Murali Reddy
On Oct. 8, 2013, 11:58 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 0ab2515
> client/tomcatconf/componentContext.xml.in 157ad5a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 92f5eeb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 1b7a7d8
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java 885a60f
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java 3a38020
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java c655b0b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java 5195793
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 8a3ca1b
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java d169b37
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java acd1bed
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java bad2502
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java f9e7c24
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 4c8c2e9
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 06daf12
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 6f0ecf2
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java aa4e9d5
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java f3884fb
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java b90792c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 9c8b61d
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java ca90666
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java 8e238fd
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java ff08560
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 7abb40a
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 7cd420c
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 4b05e96
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java f65bfc7
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 0ec7c9e
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java df40025
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 99ab944
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java 029950a
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java c3e07d0
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 87feaa9
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 55cef7c
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java a5767c6
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml 623d188
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review27190
-----------------------------------------------------------
patch does not apply cleanly yet. Can you please ensure you are able to apply the patch on to master branch and there are no tabs and trailing white spaces.
- Murali Reddy
On Oct. 16, 2013, 6:51 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 6:51 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 49f380b
> client/pom.xml fd1f13a
> client/tomcatconf/commands.properties.in 58c770d
> client/tomcatconf/componentContext.xml.in df5b002
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 92fbab2
> plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
> plugins/pom.xml ca41dff
> tools/marvin/marvin/cloudstackConnection.py c5a4c67
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Amogh Vasekar <am...@citrix.com>.
> On Nov. 1, 2013, 4:57 p.m., Hugo Trippaers wrote:
> > commit 6b5fab2f5cd939f64b5c9c1ee8d87ca8b6f6514d
> > Author: Pedro Marques <ro...@juniper.net>
> > Date: Thu Oct 31 17:16:58 2013 -0700
> >
> > OpenContrail network plugin
> >
> > Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
> >
Reminder -
Hi,
Can you please mark this as submmited? Thanks!
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review28016
-----------------------------------------------------------
On Nov. 1, 2013, 12:19 a.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:19 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 49f380b
> client/pom.xml 3e08a9a
> client/tomcatconf/commands.properties.in e92596c
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3df28ed
> plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
> plugins/pom.xml ca41dff
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review28016
-----------------------------------------------------------
Ship it!
commit 6b5fab2f5cd939f64b5c9c1ee8d87ca8b6f6514d
Author: Pedro Marques <ro...@juniper.net>
Date: Thu Oct 31 17:16:58 2013 -0700
OpenContrail network plugin
Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
- Hugo Trippaers
On Nov. 1, 2013, 12:19 a.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:19 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 49f380b
> client/pom.xml 3e08a9a
> client/tomcatconf/commands.properties.in e92596c
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3df28ed
> plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
> plugins/pom.xml ca41dff
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 12:19 a.m.)
Review request for cloudstack and Hugo Trippaers.
Changes
-------
Update the diff according to code review comments.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs (updated)
-----
api/src/com/cloud/network/Network.java 49f380b
client/pom.xml 3e08a9a
client/tomcatconf/commands.properties.in e92596c
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3df28ed
plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
plugins/pom.xml ca41dff
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review27960
-----------------------------------------------------------
Just had a nice chat with Pedro on Skype. We ran through all the review remarks i posted and we agreed to a couple of minor changes and Pedro will submit an updated diff.
I'm ok with the patch status as is and we will leave the concerns on the guru selection for a other patch. So I intend to "ship it" the patch when the new diff is in.
- Hugo Trippaers
On Oct. 31, 2013, 8:46 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 8:46 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 49f380b
> client/pom.xml fd1f13a
> client/tomcatconf/commands.properties.in 0296de0
> client/tomcatconf/componentContext.xml.in df5b002
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f16a6f5
> plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
> plugins/pom.xml ca41dff
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
(Updated Oct. 31, 2013, 8:46 p.m.)
Review request for cloudstack and Hugo Trippaers.
Changes
-------
Adding Hugo as reviewer.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs
-----
api/src/com/cloud/network/Network.java 49f380b
client/pom.xml fd1f13a
client/tomcatconf/commands.properties.in 0296de0
client/tomcatconf/componentContext.xml.in df5b002
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f16a6f5
plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
plugins/pom.xml ca41dff
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review27762
-----------------------------------------------------------
Hey Pedro,
Nice work, there is some serious effort in getting this all done.
However i'm just a bit concerned by the way the plugin is implemented. You are breaking away from some of the established patterns we already have in CloudStack. The existing SDN solutions more or less work the same way. They are added as a provider, they use an isolation type to determine if the guru should take action and they use the network offering model to determine when to take action. Also the general way of interacting southbound is through the agent system (CloudStack managers/elements and gurus decide what to do, the agent implementation decided how to do it). While your plugin seems to be fine from the functionality perspective, not using the established patterns will make it exceedingly hard to maintain this plugin and to keep supporting it from within CloudStack core. Can you explain why you did not use the established patterns?
You are not using the agent system for the interaction southbound, how would this plugin work with a cluster of CloudStack management servers? Currently in CloudStack the agent is a unique instance in the cluster that will receive instructions from the managers, how does this work with this plugin?
The guru is checking for a specific offering that is created by the plugin. I agree with Murali here that this is not the best way of doing things. You are enforcing choices on the administrator that he might want to make himself. Also this will conflict with the new capabilities system i'm putting into place where the network orchestrator will check if a certain combination of networking types can be supported by the guru. See the network-guru-orchestration branch on git for more information on that.
Cheers,
Hugo
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/14549/#comment53940>
Why do you need the vmSpec.getUuid here and not the vm.getUuid which is already present. Then you won't have to pass the vmspec.
plugins/network-elements/juniper-contrail/pom.xml
<https://reviews.apache.org/r/14549/#comment53942>
I don't think we want to list organizations here. The only organization is Apache Software Foundation.
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
<https://reviews.apache.org/r/14549/#comment53945>
Are you actually supporting all these features in the current version of the code. I see a lot of code with just debug placeholders. To keep things clear for others reading the code you might want to limit your support for things that are actually implemented and remove placeholder functions.
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
<https://reviews.apache.org/r/14549/#comment53947>
Remove the TODO's if the code is done?
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java
<https://reviews.apache.org/r/14549/#comment53952>
author tags should not be in apache code.
- Hugo Trippaers
On Oct. 23, 2013, 6:26 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 6:26 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 49f380b
> client/pom.xml fd1f13a
> client/tomcatconf/commands.properties.in 0296de0
> client/tomcatconf/componentContext.xml.in df5b002
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f16a6f5
> plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
> plugins/pom.xml ca41dff
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
(Updated Oct. 23, 2013, 6:26 p.m.)
Review request for cloudstack.
Changes
-------
Clean diff on master branch.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs (updated)
-----
api/src/com/cloud/network/Network.java 49f380b
client/pom.xml fd1f13a
client/tomcatconf/commands.properties.in 0296de0
client/tomcatconf/componentContext.xml.in df5b002
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f16a6f5
plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
plugins/pom.xml ca41dff
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 4:39 p.m.)
Review request for cloudstack.
Changes
-------
Patch created by "git format-patch" on a new local branch tracking origin/master with the contrail plugin changes merged.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs (updated)
-----
api/src/com/cloud/network/Network.java 49f380b
client/pom.xml fd1f13a
client/tomcatconf/applicationContext.xml.in 6dda5c7
client/tomcatconf/applicationContext.xml.in 0ab2515
client/tomcatconf/commands.properties.in 58c770d
client/tomcatconf/componentContext.xml.in df5b002
client/tomcatconf/componentContext.xml.in 157ad5a
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 92fbab2
plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
plugins/network-elements/juniper-contrail/pom.xml 60ce059
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 9a84d31
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java 92f5eeb
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 00fe7d3
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java 1b7a7d8
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java bd2bdbc
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java 885a60f
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java d407edd
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java 3a38020
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java d555577
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java c655b0b
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java c517660
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java 5195793
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 271b016
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java 8a3ca1b
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java 54e2e14
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java d169b37
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java 445a2cf
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java acd1bed
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java 3c23016
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java bad2502
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java 90c67cc
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java f9e7c24
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 3571312
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java 4c8c2e9
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 8626ce1
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java 06daf12
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 91acb3a
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java 6f0ecf2
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java 4b76879
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java aa4e9d5
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java cad2ea8
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java f3884fb
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java 20796f7
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java b90792c
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 87650c1
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java 9c8b61d
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java 0e519ea
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java ca90666
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java e699fd1
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java 8e238fd
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java f29852c
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java ff08560
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 2da18ca
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java 7abb40a
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 2f27082
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java 7cd420c
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 9440937
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java 4b05e96
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java b70663e
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java f65bfc7
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 1ac0840
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java 0ec7c9e
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java 591eac3
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java df40025
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 5e5b299
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java 99ab944
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java e3e73bf
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java 029950a
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java 7cdb1a2
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java c3e07d0
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 0f682d6
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java 87feaa9
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 8d48163
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java 55cef7c
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java dccd0ff
plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java a5767c6
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties 2769c9f
plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/db.properties 04a7175
plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/log4j.properties a482e6f
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh cf033a6
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh 7476ef8
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh 90aa07d
plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml 623d188
plugins/pom.xml ca41dff
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques
Re: Review Request 14549: Rename net.juniper.contrail to
org.apache.cloudstack.network.contrail
Posted by Pedro Marques <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
-----------------------------------------------------------
(Updated Oct. 16, 2013, 6:51 p.m.)
Review request for cloudstack.
Changes
-------
Diff against master branch as requested.
Repository: cloudstack-git
Description
-------
Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
Diffs
-----
api/src/com/cloud/network/Network.java 49f380b
client/pom.xml fd1f13a
client/tomcatconf/commands.properties.in 58c770d
client/tomcatconf/componentContext.xml.in df5b002
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 92fbab2
plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ApiConnectorMockito.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ProviderTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/PublicNetworkTestConfiguration.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/commonContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/contrail.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/db.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/log4j.properties PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/providerContext.xml PRE-CREATION
plugins/network-elements/juniper-contrail/test/resources/publicNetworkContext.xml PRE-CREATION
plugins/pom.xml ca41dff
tools/marvin/marvin/cloudstackConnection.py c5a4c67
Diff: https://reviews.apache.org/r/14549/diff/
Testing
-------
Integration test passes.
Thanks,
Pedro Marques